Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [External] Re: [PATCH 0/2] IdeaPad platform profile support
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Hans de Goede <hdegoede@redhat.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>
CC:     Platform Driver <platform-driver-x86@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Mark Gross <mgross@linux.intel.com>,
        Ike Panhc <ike.pan@canonical.com>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20210101125629.20974-1-jiaxun.yang@flygoat.com>
 <35ac853a-266c-6944-6e5e-6286456865e3@redhat.com>
 <CAJZ5v0jcCD3qWUJQcS+nFVJWSCQEbq2eN3i07mN8yFr3WZD9dg@mail.gmail.com>
 <6a29f338-d9e4-150c-81dd-2ffb54f5bc35@redhat.com>
 <2eefa5ec-4f09-eabd-2c20-f217fa084dfc@lenovo.com>
 <75952842-3ee3-82a2-7809-66e2d5263c73@flygoat.com>
From:   Mark Pearson <markpearson@lenovo.com>
Message-ID: <f53cd0dc-17b4-6410-02f9-526e67c7132c@lenovo.com>
Date:   Tue, 5 Jan 2021 11:53:41 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <75952842-3ee3-82a2-7809-66e2d5263c73@flygoat.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Jiaxun,

On 05/01/2021 01:24, Jiaxun Yang wrote:
> 在 2021/1/5 上午5:58, Mark Pearson 写道:
>> On 04/01/2021 15:58, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 1/4/21 9:33 PM, Rafael J. Wysocki wrote:
>>>> On Mon, Jan 4, 2021 at 3:36 PM Hans de Goede <hdegoede@redhat.com>
>>>>   wrote:
>>>>> Hi,
>>>>>
>>>>> On 1/1/21 1:56 PM, Jiaxun Yang wrote:
>>>>>> Tested on Lenovo Yoga-14SARE Chinese Edition.
>>>>>>
> [...]
>> Just for my understanding of what happens next....please correct me if I
>> have anything wrong:
>>
>>   - platform_profile gets pulled from ACPI for 5.11
>>
>>   - platform_profile gets updated to add this data/pointer implementation
>> and goes into 5.12.
> Hi all,
> 
> Another approach could be just let all the patch go through pdx86 tree
> and with
> pointer part acked by Rafael as it's unlikely to have merge conflicts.
> 
>> Jiaxun, let me know if you're happy with following
>> up on that based on Hans suggestions, If you are pushed for time let me
>> know and I'll happily help out/implement/test as required. I sadly don't
>> have any ideapads but very happy to support your efforts any way I can.
> 
> 
> I'm happy with Hans suggestion, will send v2 for it later.
> 
> I've been ask Lenovo engineers about DYTC and other ideapad ACPI
> stuff on Lenovo China forum[1], but moderator here told me Lenovo won't
> invest any Linux effort on their consumer product line :-(
> 
> Is it possible to publish a DYTC specification or documents to help us
> further
> understand these mechanisms?
> 
> I'm tired of reading disassembly AML and code to figure out these
> internals.
> 
I hear you :)

Afraid I'm not allowed to publish the full DYTC spec - but I make public
the bits that I can.

I don't have many hooks into the ideapad team as it's not in the Linux
plan - so I can't answer your questions with confidence. I am going to
ask the firmware team if they can confirm if ideapad is using the same
spec - it would make sense if they are.
Feel free to bug me off mailing list and I'll happily help out with any
debugging issues.

I'm also not allowed to confirm or deny future plans but my personal
hope is that the Linux project in Lenovo grows. Fingers crossed for the
future.

>>
>>   - Can we get the x86 portion done at the same time or does that end up
>> going to 5.13? I had been looking at the ideapad_laptop.c patch and have
>> some concerns there as Jiaxun's patch is essentially a duplicate of what
>> I implemented in thinkpad_acpi.c which doesn't seem to be ideal
>> (especially as there is a V6 version of DYTC coming out this year). I
>> haven't had time to look at code to consider better alternatives
>> though...
> 
> It may be worthy to share these code but I'm comfort to have this
> duplication as I'm
> unsure about the future of DYTC. Will DYTC for thinkpads always coherent
> with DYTC
> for ideapads?
I'll see if I can find out.

> 
> Thanks.
> 
> [1]: https://club.lenovo.com.cn/thread-5980431-1-1.html
> 
> - Jiaxun
> 
>>
>> Mark
>