Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp408051pxu; Tue, 5 Jan 2021 14:45:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgx5RLXeLO+TgCEGOrDpvIP/hNlN0dH5tFPWUgCDThdc2cHmTjqdmnBNruvg90qJasPewx X-Received: by 2002:a50:fd18:: with SMTP id i24mr2024316eds.146.1609886711453; Tue, 05 Jan 2021 14:45:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609886711; cv=none; d=google.com; s=arc-20160816; b=EAfmEt6T7gIMbh1QsehQ0hCIGkVIUZpL0snbglKMNeID+aK4fxC7TPjIEi6CK+WAw9 38F8WPgyreyKA4T0MBCMs7i4kxuXEiEW0KXPkdruCbpFBt5TODpYHtXnfY6bFIE3eJmD Rhgr2pMo8FhLwPRNoB4kRDhRNTvBgHH1X17wZwGjB8SJQQp0p3Sr2CgkfgVyf3qboCNf fG28UM5MTIucVCeJuj5HCRQHeKDuyYLQTj6y644HjJnjZpBd45yAA8Me/t4xptDfr58M ffzkrllV7paluaSxopL7MoLPAUTGv7NPC2vGpSuSvIJvn39lmWXX0gcaRlsTr7B1xJBC akBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=/uf2XQkjmS6W7PKKesbRc3QvpPXneXjuwgCuBFE/hMo=; b=pgskE/OKwg0py9JV9PGP4cjSoc0SCxECwrFFLuJQE4FMNBJ+VuK7Kc4q0LGINYTumm QWG+7vRJmTo7ePUZriGkP+T2kUg3k0NHaR28XfjsXvEY+vt5g9oKNSUmpiHXNp4suD1V 5HDaFHru8T4A/OU6hq71qhwgG9RvGhx8AiZxgOw7OAC6y5dMFfzd+igz/DExCoB1kTl6 QVyWAYBL8u3L5SlfAhhuKrVxTr4KJ6dMW3PPg1DaOwy58U2hBaDkR/ilOnMoK+SE3VWw pO55fBFgunFRCWuxR/S6qPISWpG2c5JN+ECIyOkzphb0zTSrtOsJKsMVBUPWorwGyVxO bp4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=aJRkYBut; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si217958edq.66.2021.01.05.14.44.48; Tue, 05 Jan 2021 14:45:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=aJRkYBut; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729208AbhAETyt (ORCPT + 99 others); Tue, 5 Jan 2021 14:54:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbhAETyt (ORCPT ); Tue, 5 Jan 2021 14:54:49 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7570BC061795 for ; Tue, 5 Jan 2021 11:54:08 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id l11so1359484lfg.0 for ; Tue, 05 Jan 2021 11:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/uf2XQkjmS6W7PKKesbRc3QvpPXneXjuwgCuBFE/hMo=; b=aJRkYButiDTQqAzxp0oHMiKq3+wTDqLaHNusBBared9b+2eNkAaLlL5/R/KL3BO2RU YulslaZbXvbBumlCNJqnIWN3MB/9CPWNiqyvF0VokMujseO9NWic1W+fBW7Bw6xdCwLN rL8LCIRdmuFwxFUyVRFng9yBvPbqayX8+3zAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/uf2XQkjmS6W7PKKesbRc3QvpPXneXjuwgCuBFE/hMo=; b=pdJHIAzz4W4tRsI4W8rfUHRA0g8BOcbiM7s8aeoUemmcVzX7lc6MeAv4+V2V+dRPxP sYx1B+Zc/lW50O7clYdf5nW9k1sfYVczYnPlEPvGDltkNpbTJ+RF/ZdtLP7iJt2VynZN f6m1MucAyUE2juEFmFcXFIrpThfbBZNsquGJKwe3TYn6y0ua3oQsDEChXcubWvyy9noY QJR9q67zDivh1MHu55Ylkrt4dmDqMRHalYBBJ/3q2zS34Sgan0m3jplVoZd2PHAAV+jz A4dKGXBrGUnBCWBoxV/LqPbDrhi2SyLzHZr6SA3fXGYkqaP7O8AyZ3g/L8Yr7UIQSyHI SfBQ== X-Gm-Message-State: AOAM530a5jVUYURVqq9/kklpQx4zJEoTUiF9TUNZtP1za0s5LQaumEf3 PHifdUSUS0wGwEsrnqa5cJMnueQTgO/Y5Q== X-Received: by 2002:a19:fc1b:: with SMTP id a27mr347325lfi.349.1609876446596; Tue, 05 Jan 2021 11:54:06 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id h13sm16821lfj.110.2021.01.05.11.54.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 11:54:05 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id 23so1204290lfg.10 for ; Tue, 05 Jan 2021 11:54:04 -0800 (PST) X-Received: by 2002:ac2:4987:: with SMTP id f7mr362618lfl.41.1609876444687; Tue, 05 Jan 2021 11:54:04 -0800 (PST) MIME-Version: 1.0 References: <000000000000886dbd05b7ffa8db@google.com> <20210104124153.0992b1f7fd1a145e193a333f@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Tue, 5 Jan 2021 11:53:48 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: kernel BUG at mm/page-writeback.c:LINE! To: Hugh Dickins Cc: Andrew Morton , Matthew Wilcox , syzbot , Linux Kernel Mailing List , Linux-MM , syzkaller-bugs Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 5, 2021 at 11:31 AM Linus Torvalds wrote: > > On Mon, Jan 4, 2021 at 7:29 PM Hugh Dickins wrote: > > > > > So the one-liner of changing the "if" to "while" in > > > wait_on_page_writeback() should get us back to what we used to do. > > > > I think that is the realistic way to go. > > Yeah, that's what I'll do. I took your "way to go" statement as an ack, and made it all be commit c2407cf7d22d ("mm: make wait_on_page_writeback() wait for multiple pending writebacks"). Linus