Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <160988059854.2071197.11821323682102566548.stgit@dwillia2-desk3.amr.corp.intel.com>
 <3c31c3328f569f15f03de9eb8d1b6a9ae4862893.camel@intel.com>
In-Reply-To: <3c31c3328f569f15f03de9eb8d1b6a9ae4862893.camel@intel.com>
From:   Dan Williams <dan.j.williams@intel.com>
Date:   Tue, 5 Jan 2021 13:51:16 -0800
Message-ID: <CAPcyv4jc3t8Vdes6Mu=HG=ro_Gg3nVck=_tWMPiOEPBm3M1qiw@mail.gmail.com>
Subject: Re: [PATCH] ACPI: NFIT: Fix flexible_array.cocci warnings
To:     "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc:     "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
        "efremov@linux.com" <efremov@linux.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        lkp <lkp@intel.com>,
        "julia.lawall@inria.fr" <julia.lawall@inria.fr>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 5, 2021 at 1:28 PM Verma, Vishal L <vishal.l.verma@intel.com> wrote:
>
> On Tue, 2021-01-05 at 13:03 -0800, Dan Williams wrote:
> > Julia and 0day report:
> >
> >     Zero-length and one-element arrays are deprecated, see
> >     Documentation/process/deprecated.rst
> >     Flexible-array members should be used instead.
> >
> > However, a straight conversion to flexible arrays yields:
> >
> >     drivers/acpi/nfit/core.c:2276:4: error: flexible array member in a struct with no named members
> >     drivers/acpi/nfit/core.c:2287:4: error: flexible array member in a struct with no named members
> >
> > Instead, just use plain arrays not embedded a flexible arrays.
>
> This reads a bit awkwardly, maybe:
>
>   "Just use plain arrays instead of embedded flexible arrays."

yeah, umm, I left that extra "a" in there as a test... you passed! :)

>
> Other than that, the patch looks looks good:
> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>

Thanks.