Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp419629pxu; Tue, 5 Jan 2021 15:08:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnH182eanQpunmkdWvinBmY1qhs7n+4Ro3SHBLp1htpQ2BzyZXccK8+gv67EsMA/wBn6SS X-Received: by 2002:aa7:df0f:: with SMTP id c15mr2060034edy.354.1609888083709; Tue, 05 Jan 2021 15:08:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609888083; cv=none; d=google.com; s=arc-20160816; b=Bhpo0L1odxJ+OkiOaKdv+m6k2YHHTK33OgMsBKaGd1A0VN1QAa3RpbhHixWDDV5ldw k1SGF7nUW14e6BBjOFoGkSXRFDEYnBOBNvNZ3RqevwncoUHwlgprY2rdSTcAoejewO/3 3EvxLl9b7sb5sc289failwbet025TY6Bj7sWEjJjT45BlCyF0aCJ1+YWSAxB7b5ivh8a jXf+tgFfl3rNLAPjTYgbCowVIsPRQnW8wUJi2g72wpvUCOXP5CcqLyxb8wzQB6cR1h2t CUrUjVPln+UovhpxUgnGwsLkes5O1+MpvpssPY0xcjZSC6VsDUPooIllDxyTgqvvWl3+ 3sLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=PhKJPw0HSB7EdfRFRppJ/B8zQwnwjJgh/MdRymWFGuQ=; b=DnuFIwIOztpnhkxfM9NVc7JfJHGm/vbGDOMPLb+Bvi4PCv+Lsq5psG0YeMa4K6IHQG Zz3Tr34arx21pC04evtZOVFzvVnHqx6eNg3DkYVSKRe3meH1bjoPhFYNk0sIbvFGD13/ YXzGtVn58BbaTLpJwcLrTmmO5wH6byBOE96/IosjcXjE7jAQ/E870Un5FVhzc8V8a19C 5Tf584GpyMxapx9lC1rUSJge3tnvd48AXoxT3KvbCJWIbv+o4x6Fph08UybKm0unA0Bm 6+6KE3BsDRXG6Bz6Q1cI+2FtaaLRRVb/HH9jX4hOF73YHvRHk4aAml5GwAIrOGZ7CwuP XqAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sb9si256089ejb.219.2021.01.05.15.07.40; Tue, 05 Jan 2021 15:08:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbhAEWSH (ORCPT + 99 others); Tue, 5 Jan 2021 17:18:07 -0500 Received: from mga14.intel.com ([192.55.52.115]:63856 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728228AbhAEWSG (ORCPT ); Tue, 5 Jan 2021 17:18:06 -0500 IronPort-SDR: zWEH3ZLwEAp2CA4Z74xbuND1Kcbznj/pT8Ifzphj9VZ1jv+I0SImy3dlDfulqkNCC3QDO6Aokh JnY8Yqo1nyYA== X-IronPort-AV: E=McAfee;i="6000,8403,9855"; a="176406625" X-IronPort-AV: E=Sophos;i="5.78,478,1599548400"; d="scan'208";a="176406625" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 14:17:25 -0800 IronPort-SDR: q7peCkp/SdkLFC6uxgWZ1uDaVugFE3NQsHY+95gxj08JEcU+dAV6fDUAGt4vhKOm52QtPszQA7 W+yv59DH6zYg== X-IronPort-AV: E=Sophos;i="5.78,478,1599548400"; d="scan'208";a="397996669" Received: from mishravi-mobl3.amr.corp.intel.com (HELO [10.209.147.102]) ([10.209.147.102]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 14:17:25 -0800 Subject: Re: [PATCH 2/2] x86/mm: Remove duplicate definition of _PAGE_PAT_LARGE To: Arvind Sankar Cc: Tom Lendacky , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <13073a85-24c1-6efa-578b-54218d21f49d@amd.com> <20201111160946.147341-1-nivedita@alum.mit.edu> <20201111160946.147341-2-nivedita@alum.mit.edu> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Tue, 5 Jan 2021 14:17:25 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/5/21 1:28 PM, Arvind Sankar wrote: > diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h > index 394757ee030a..f24d7ef8fffa 100644 > --- a/arch/x86/include/asm/pgtable_types.h > +++ b/arch/x86/include/asm/pgtable_types.h > @@ -177,8 +177,6 @@ enum page_cache_mode { > #define __pgprot(x) ((pgprot_t) { (x) } ) > #define __pg(x) __pgprot(x) > > -#define _PAGE_PAT_LARGE (_AT(pteval_t, 1) << _PAGE_BIT_PAT_LARGE) Huh, I didn't realize that duplicate #defines were allowed. Guess you learn something new every day. This looks fine to me, it removes the exact dup that Ingo appears to have added. Acked-by: Dave Hansen