Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp419657pxu; Tue, 5 Jan 2021 15:08:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8asee6dNTAy9/KGd3S/vBKW1EZEl1Bs8PxC2Qa2yTTzlnpNCN3ES1xQnAmTUeCNgAKMAv X-Received: by 2002:a17:906:da08:: with SMTP id fi8mr1086938ejb.517.1609888085066; Tue, 05 Jan 2021 15:08:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609888085; cv=none; d=google.com; s=arc-20160816; b=X2JXL8eJyDvsfrC/k8KiMO/FMMJtFcDTJhdtEG6UzNpHzhAizNlDxjn5PrqgNgefnh VOhTsbYUpw8Wn3PTl/hPhGVXO9d5BXy385lWYHzs1L7Na4df65qK4gt12slifVDJjCdO LNHmo3dGApE1TpoTkmizl+ZumrsfTUlvANTQyvEsbcVjgMmVa5MR2RZCkREwr3+rAILA LZudNCJXhXgqUSIhtzPr0/ozA5/z00FYfnSxz78lz2s2QlCrI2s6+F9pwXbYgwsElLas /FaSUHGM/WvLO8K56grh2QwcamNvDW/ZGdR2eB3z+eP6Mw9BnLwgRlOOIYU4OpSfJkud saTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JK9SGxvybr3by1n8VGP6KgFtd/JCDCNc/wCRVLEBq4Y=; b=jshYqjyw8r8Ph+Gmm7Dw6pkMwzJ4YFxufeJ7IPhGcbNg3WIuVNfneKqWy4W/gZNq2d DB+q7VlzYhUdvDAkgSd2WVbUV+NqvgCK0NLDImn9idDmOylEsxXJBp4YQH3RQoHdoxYX I9Pzq5jYZ8kErP2FXaGTxBOx9MDS7jbWewP01XdJpKCYJ0WLlJbhGxIfKWatS75Kl0tR DhDlRJnpnQPoCNSxpSiB3UxjNg7kmVFzTL+5ScXgrU8YFNKTrxpC+3DnUt2nzPTcMFb3 yKxANtkRYPuoWIO42RqRtr1QIdJxfwNg4d9xn3IzqkpCs4QTq1PPR8+G1gaDmXXyLD+6 KnRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ExbI2M6U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h17si263790ejg.46.2021.01.05.15.07.41; Tue, 05 Jan 2021 15:08:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ExbI2M6U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731620AbhAEWHz (ORCPT + 99 others); Tue, 5 Jan 2021 17:07:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:40230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729419AbhAEWHy (ORCPT ); Tue, 5 Jan 2021 17:07:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6515622EBE; Tue, 5 Jan 2021 22:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609884434; bh=6X9xh0B9e7jk8zQM37gLnc6Rfvt46/YI3ULCrl4E+0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ExbI2M6Ui3QyfRBhdrUi7GpiKAJoN6lx5R4MfJLgOWjxo94nPJ2V6ghl3wUF/luK7 Y0Q6HsQvwtYkanU46yCVavoHUnH5sOBwbPdiVrKV2KqLeq+jPejkwETiOqTJFFYUGR n77h+H235XHE9447prM8u7AkJflwIH/tp1Xvr/lhDRUjb8WI1y1kqU0gb0DUOWmmLp otXxR6PDgOlhl3n7yom/QPeXzid6FSzwyZKoajluUI1Zvm6uyrY5TZPPb7nKIREldm NHuVs4IhlmtOgs/wOgCntK7Gr/o9Z9uE/NSJvYaX07Wn0a/KHW3hHCyqmhxZYM4VAu PNsHZdQiXlrVg== From: Will Deacon To: Johnathan Smithinovic , mingo@redhat.com, David Woodhouse , tglx@linutronix.de, bp@alien8.de Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , x86@kernel.org, linux-kernel@vger.kernel.org, iommu Subject: Re: [PATCH] iommu/amd: Stop irq_remapping_select() matching when remapping is disabled Date: Tue, 5 Jan 2021 22:07:02 +0000 Message-Id: <160987465284.30865.16684216909917986687.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <04bbe8bca87f81a3cfa93ec4299e53f47e00e5b3.camel@infradead.org> References: <04bbe8bca87f81a3cfa93ec4299e53f47e00e5b3.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 05 Jan 2021 01:36:13 +0000, David Woodhouse wrote: > The AMD IOMMU initialisation registers the IRQ remapping domain for > each IOMMU before doing the final sanity check that every I/OAPIC is > covered. > > This means that the AMD irq_remapping_select() function gets invoked > even when IRQ remapping has been disabled, eventually leading to a NULL > pointer dereference in alloc_irq_table(). > > [...] Applied to arm64 (for-next/iommu/fixes), thanks! [1/1] iommu/amd: Stop irq_remapping_select() matching when remapping is disabled https://git.kernel.org/arm64/c/b34f10c2dc59 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev