Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 5 Jan 2021 14:41:22 -0800
From:   Benson Leung <bleung@google.com>
To:     Prashant Malani <pmalani@chromium.org>
Cc:     Utkarsh Patel <utkarsh.h.patel@intel.com>,
        linux-kernel@vger.kernel.org, enric.balletbo@collabora.com,
        bleung@chromium.org, heikki.krogerus@linux.intel.com,
        rajmohan.mani@intel.com, gwendal@chromium.org
Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux
 configuration acknowledgment to EC
Message-ID: <X/TrEgQf5l8yHKrx@google.com>
References: <20201210060903.2205-1-utkarsh.h.patel@intel.com>
 <20201210060903.2205-3-utkarsh.h.patel@intel.com>
 <X+FBsu+VNsEJlgBp@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VIrzktiWRp/YXkuU"
Content-Disposition: inline
In-Reply-To: <X+FBsu+VNsEJlgBp@google.com>
Precedence: bulk


--VIrzktiWRp/YXkuU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Prashant and Utkarash,

On Mon, Dec 21, 2020 at 04:45:38PM -0800, Prashant Malani wrote:
> Hi Utkarsh,
>=20
> On Wed, Dec 09, 2020 at 10:09:03PM -0800, Utkarsh Patel wrote:
> > In some corner cases downgrade of the superspeed typec device(e.g. Dell
> > typec Dock, apple dongle) was seen because before the SOC mux configura=
tion
> > finishes, EC starts configuring the next mux state.
> >=20
> > With this change, once the SOC mux is configured, kernel will send an
> > acknowledgment to EC via Host command EC_CMD_USB_PD_MUX_ACK [1].
> > After sending the host event EC will wait for the acknowledgment from
> > kernel before starting the PD negotiation for the next mux state. This
> > helps to have a framework to build better error handling along with the
> > synchronization of timing sensitive mux states.
> >=20
> > This change also brings in corresponding EC header updates from the EC =
code
> > base [1].
> >=20
> > [1]:
> > https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/m=
aster/include/ec_commands.h
> >=20
> > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
>=20
> I'm not sure what the maintainers' preference is for the header (same
> patch or separate patch). FWIW:
>=20
> Reviewed-by: Prashant Malani <pmalani@chromium.org>

I asked Gwendal to look over this change. It looks good to him, so I've gone
ahead and merged it.

At some point we have to completely sync ec_commands.h, but the change here
is well contained, so it minimally adds to the delta between the EC codebas=
e's
header and the kernel's.

Thanks,
Benson
--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--VIrzktiWRp/YXkuU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCX/TrEgAKCRBzbaomhzOw
wkWGAQCYV3oXFdaXYJ6sx+y9ZhPZDkUiYLgOVKc1u/5uyAANCwEA1RbY5KhJAhvg
+rSbzzIM64Ia+DVtmvQVI9IZafWCjgE=
=5hU0
-----END PGP SIGNATURE-----

--VIrzktiWRp/YXkuU--