Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp420852pxu; Tue, 5 Jan 2021 15:10:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJyjEBG2L3FzX5L9FTYtEGHWZUsmrJDknFJV9lhaQ1/kswZFjw8Lyn5O816/AwyQhZKwLyxc X-Received: by 2002:a05:6402:3074:: with SMTP id bs20mr1992486edb.365.1609888218328; Tue, 05 Jan 2021 15:10:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609888218; cv=none; d=google.com; s=arc-20160816; b=zBzvuR1uN9ZBEjDiaJLeLkYgt4Mixp20QkiFad52mmipSk5fjMblboI+j2unTw69AN 5UKdJ7+5dzusruT6BS4DQ8UVJTmN09IcvFzYCF79MG8wC6lmpSLTTuWw9V552viorEZv QDp6bPvLfv+9TgJH1MaqtwrSOQmiz97I6l/4Smz6mwSaU7HufMC6eWtZAdGnVL0bfqcC OJdfBixr7cEa/I4MSglcIu6x83MMdqfT9rU4pj8b0H8JNoFdT6L8KJnWUsASh6ZIDX5D ezLyK8cjSO/JKSUItQb5mfxM/WO3/DaC7KBIB4N1kVwKG6KhJ2AnuIp2I/d/gupZGTip NEHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=A9uJ+mRMwMNCjTDA7H/Mm7rI4bw9j4iKv8gt3pZkI1A=; b=GuEwQs7PmKTXds7eDxfbxTunAlzap+FSPt05fwBp2tpGto00B/ytn5Fgmi/+jSKDSB aELgMYg3iYmsC+3JBQfasdquMotJeEy6S11dvIHclfntwH5Ont2JRdvZRr4oieASt0eO sDWpgumRdxbfearM4KzOCaEm3rLXf2+nelCt9kZNEqFuglXp6gUy4wxwOTU0XOS6dRwT gktMmN/Cw/gQFBYEzCpGtnqP35bjZc4YMy7H7U+YtGY0iuFtsCNcZ9/+/bVA+I8uPO4r e1cHxJdJ9Wr152CY+Tr8UewGGVvrFL60mZng6IZZCGr7DzbCHfNuIYwH2CcRQ7vT8TEC l7Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Iox6T65s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v25si223301edt.63.2021.01.05.15.09.55; Tue, 05 Jan 2021 15:10:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Iox6T65s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730830AbhAEWlb (ORCPT + 99 others); Tue, 5 Jan 2021 17:41:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728224AbhAEWla (ORCPT ); Tue, 5 Jan 2021 17:41:30 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C79D6C061793 for ; Tue, 5 Jan 2021 14:40:49 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id m12so2239558lfo.7 for ; Tue, 05 Jan 2021 14:40:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A9uJ+mRMwMNCjTDA7H/Mm7rI4bw9j4iKv8gt3pZkI1A=; b=Iox6T65sT6cbzUPZGs6r2WT1UcGm50nonReKeZ1J9nPB9NCFRrTteX4vpPI+xFbO5l DyJRrwiNFFCbY2XIBy3K9qn3WvApzDXm1+kiDGRu5h/EGoadlZzUNz3BD/CFOc8WTXEz vPdh6UWNFEgHmXg4bZNO3U9Ka3Nq2kFEdazHzEGZywA0RGy1DE5NVGloXaV3mAg2Ci0y WT6ZnmvP8TLpc5Aqr8jJWsz0EkjwjZGg1azMyix5WFrmrIoyomnN14DFpNfvrk+APLTw DLLRg6m2/zNcpCXLQYOZrTiBQ91ZhMLBFoYQnf7H2al5YY6LENFsEZFLDFTQ+mOq3eqr 6i1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A9uJ+mRMwMNCjTDA7H/Mm7rI4bw9j4iKv8gt3pZkI1A=; b=HQng6+MK0HY8VciVgI+Sp6agR/tJub8f7OAHIsviC8t5Cx6lS3xDP5AL8w7QhtMz7F gfaKgNoPnJPqzUG47KxDHqauRFZfBmc1bvV34DbDxEyn8dX1swBd0qmzNO75QqRauGpg 1eK6FI+S93GqEmpUghNAHZwIQ0dHGX/ZM3UDJCa9tXKdsPAEmUD+aufpAHn0ORtthi+W eWFpfPjPy/fcpQ0nhf00KCrmWbacVFNf4hhBS9/IePeOsTVQTgnTzTMmtwlSjoRnrTbJ ZnlQ5BG4LhYS4pQOJKhqROLY9xTAi5A4BgrRK2KGHqyHGoBB9NlrHCHr3VCWJPMCOxlU tJcw== X-Gm-Message-State: AOAM530SqZ4MWmJeLUpt/eg2w5nLECryxuxU5A6I6WrGq1hZ4ELBGQGj ULlnwlpJ/sfOKVKbtQByvly8bIay3wVHMZHiO9i6MA== X-Received: by 2002:ac2:5597:: with SMTP id v23mr563643lfg.649.1609886448380; Tue, 05 Jan 2021 14:40:48 -0800 (PST) MIME-Version: 1.0 References: <20201228090425.2130569-1-hsinyi@chromium.org> In-Reply-To: <20201228090425.2130569-1-hsinyi@chromium.org> From: Linus Walleij Date: Tue, 5 Jan 2021 23:40:37 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: mediatek: Fix fallback call path To: Hsin-Yi Wang Cc: Linux ARM , Sean Wang , Matthias Brugger , Light Hsieh , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Enric Balletbo i Serra Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 28, 2020 at 10:04 AM Hsin-Yi Wang wrote: > Some SoCs, eg. mt8183, are using a pinconfig operation bias_set_combo. > The fallback path in mtk_pinconf_adv_pull_set() should also try this > operation. > > Fixes: cafe19db7751 ("pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage") > Signed-off-by: Hsin-Yi Wang Patch applied for fixes! Yours, Linus Walleij