Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [EXTERNAL] Re: [PATCH v9 2/2] power: supply: bq256xx: Introduce
 the BQ256XX charger driver
To:     Sebastian Reichel <sre@kernel.org>
CC:     <robh+dt@kernel.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <dmurphy@ti.com>
References: <20210105202949.14677-1-r-rivera-matos@ti.com>
 <20210105202949.14677-3-r-rivera-matos@ti.com>
 <20210105212631.2meujp37e5jqp7eu@earth.universe>
From:   Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Message-ID: <430133d5-6a30-8cfd-2483-f4b849bf90bd@ti.com>
Date:   Tue, 5 Jan 2021 17:27:08 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210105212631.2meujp37e5jqp7eu@earth.universe>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Sebastian,

On 1/5/21 3:26 PM, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Jan 05, 2021 at 02:29:49PM -0600, Ricardo Rivera-Matos wrote:
>> The BQ256XX family of devices are highly integrated buck chargers
>> for single cell batteries.
>>
>> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
>>
>> v9 - resolves two warnings issued by kernel test robot
> changelog needs to be below --- btw.
> (so that git am does not pick it up :))
ACK
>
>> ---
>> [...]
>> +	ret = bq256xx_parse_dt(bq, psy_cfg, dev);
>> +	if (ret) {
>> +		dev_err(dev, "Failed to read device tree properties%d\n", ret);
>> +		return ret;
>> +	}
>> [...]
> If you want to change psy_cfg, you need to pass it by reference
> and not by value (i.e. use &psy_cfg here and a pointer as argument
> of bq256xx_parse_dt). Providing psy_cfg like this creates a copy
> of the struct.
ACK, understood.
>
> Did you runtime test this version? It should crash when accessing
> the properties because of psy_cfg.drv_data being NULL.
ACK, I did not, my mistake. v10 will get tested on the actual hardware.
>
>> [...]
>> +	ret = bq256xx_power_supply_init(bq, psy_cfg, dev);
>> +	if (ret) {
>> +		dev_err(dev, "Failed to register power supply\n");
>> +		return ret;
>> +	}
> Here it's also better to just provide the address of psy_cfg
> (but not strictly necessary).
>
> -- Sebastian
Thanks,
Ricardo