Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210105041630.1393157-1-daeho43@gmail.com> <dba4be04-70dd-d48b-391c-1f2355591097@web.de>
In-Reply-To: <dba4be04-70dd-d48b-391c-1f2355591097@web.de>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Wed, 6 Jan 2021 08:44:53 +0900
Message-ID: <CACOAw_xXPZm65BD0SAwFECyEMCD0i_g+7mKyd+=Gtm3p-W19og@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty_blocks
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     Daeho Jeong <daehojeong@google.com>,
        linux-f2fs-devel@lists.sourceforge.net,
        kernel-janitors@vger.kernel.org,
        Colin Ian King <colin.king@canonical.com>,
        kernel-team@android.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Got it~

Thanks,

2021=EB=85=84 1=EC=9B=94 5=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 9:06, Ma=
rkus Elfring <Markus.Elfring@web.de>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> > Fixed null page reference when find_lock_page() fails in
> > redirty_blocks().
>
> I suggest to choose an other imperative wording for this change descripti=
on.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D=
ocumentation/process/submitting-patches.rst?id=3D36bbbd0e234d817938bdc52121=
a0f5473b3e58f5#n89
>
>
> > v2: changed error value and break the loop when error occurs
>
> I propose to use a return statement instead of a break in the second if b=
ranch
> for this function implementation.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D=
ocumentation/process/coding-style.rst?id=3D36bbbd0e234d817938bdc52121a0f547=
3b3e58f5#n481
>
> Regards,
> Markus
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel