Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp440020pxu; Tue, 5 Jan 2021 15:53:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFG9AzYQymYairslhWxgs60OQNhw1va+K7Gxwpsr2X4WcUOx9XdDLYgu/mNEFtECNeOn2v X-Received: by 2002:a17:906:a48:: with SMTP id x8mr1186299ejf.444.1609890822060; Tue, 05 Jan 2021 15:53:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609890822; cv=none; d=google.com; s=arc-20160816; b=YjSPewcA6GxnYlOIqBFP38ILQGT5oP62QFbh3lvN6mMZkPx0DvXu1u3dH2Z+IUX8GL Yzg9HML2Ktc6KR9aDEDYqNbPMwrVeSS45aBeGSbH9S6XPax4nGDGANbHNUWRgk1WGxKe DqUOL//0F81WHPud8Fhs+tS8il8Xu1MVcwJCKZsFRyje6qu5R+sYv1uDoyrpEHz/NHYV jKWOxTdIP7Bg1ngiArp5pspVvmPrkTnIMzY36TN1MJHRWCN3mkCoeNz6XNIsYCMWEK4a TMPWYFinthKmr69T5TPALo49FKZr3vQc1lI9xq/CzKqHGo4TG8aGz4Wl5p5Q14BGrbwg 9YFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:cc:to:subject:from:date; bh=jsp+aZKMhakTPU4C12vxJKSSwMpv8HE+kGiniVoN2NY=; b=w5JIYvcibb7tHdWsC8gcdeFssaOZdOLtgh2cw/NeJrbdWKKdFRdTvTzbpBJm0L0gVP rllif6qclqPrm36P2HWKuXyCvKdvRA0umHaxgl/p9qkQyp7naJCKXhnkoZq8lSljlUhy xD9ej6oZ67z00Br/2MooOG6UVho64Xtiq8CGLcZ/QOCd9fFNRfjMJ91oOXF6pUH1Sq5r McDxSjzkPK/lp9rXKWa/88lO3uEtG8hUZYLMFT3BXbwQctRh7X96tGp5mQ/103I3CZs3 qeciBMrqQdr8XVoC1rNzKH0mVYv1cvE/hSm2gLdeD5ZNI/tjqLEMHiUfI9pGJZsy69zA 7Ecg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jz8si277526ejb.237.2021.01.05.15.53.18; Tue, 05 Jan 2021 15:53:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727425AbhAEXuY convert rfc822-to-8bit (ORCPT + 99 others); Tue, 5 Jan 2021 18:50:24 -0500 Received: from aposti.net ([89.234.176.197]:33650 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbhAEXuW (ORCPT ); Tue, 5 Jan 2021 18:50:22 -0500 Date: Tue, 05 Jan 2021 23:49:18 +0000 From: Paul Cercueil Subject: Re: [PATCH] dt-bindings: Add missing array size constraints To: Mathieu Poirier Cc: Rob Herring , devicetree@vger.kernel.org, Ulf Hansson , linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, Linus Walleij , linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-ide@vger.kernel.org, Thierry Reding , netdev@vger.kernel.org, linux-clk@vger.kernel.org, Chanwoo Choi , Marc Zyngier , linux-riscv@lists.infradead.org, Bartosz Golaszewski , Chen-Yu Tsai , MyungJoo Ham , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , linux-media@vger.kernel.org, Ohad Ben-Cohen , linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Jens Axboe , Stephen Boyd , Greg Kroah-Hartman , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sebastian Reichel , "David S. Miller" , Jonathan Cameron , s-anna@ti.com Message-Id: <6IJHMQ.19OBCF0P9Z4X2@crapouillou.net> In-Reply-To: <20210105232729.GA2864340@xps15> References: <20210104230253.2805217-1-robh@kernel.org> <20210105232729.GA2864340@xps15> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le mar. 5 janv. 2021 ? 16:27, Mathieu Poirier a ?crit : > Adding Suman and Paul - guys please have a look. > > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: >> DT properties which can have multiple entries need to specify what >> the >> entries are and define how many entries there can be. In the case of >> only a single entry, just 'maxItems: 1' is sufficient. >> >> Add the missing entry constraints. These were found with a modified >> meta-schema. Unfortunately, there are a few cases where the size >> constraints are not defined such as common bindings, so the >> meta-schema >> can't be part of the normal checks. >> >> Cc: Jens Axboe >> Cc: Stephen Boyd >> Cc: Thierry Reding >> Cc: MyungJoo Ham >> Cc: Chanwoo Choi >> Cc: Linus Walleij >> Cc: Bartosz Golaszewski >> Cc: Jonathan Cameron >> Cc: Dmitry Torokhov >> Cc: Thomas Gleixner >> Cc: Marc Zyngier >> Cc: Mauro Carvalho Chehab >> Cc: Chen-Yu Tsai >> Cc: Ulf Hansson >> Cc: "David S. Miller" >> Cc: Jakub Kicinski >> Cc: Sebastian Reichel >> Cc: Ohad Ben-Cohen >> Cc: Bjorn Andersson >> Cc: Greg Kroah-Hartman >> Signed-off-by: Rob Herring >> --- >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-ide@vger.kernel.org >> Cc: linux-clk@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> Cc: linux-gpio@vger.kernel.org >> Cc: linux-iio@vger.kernel.org >> Cc: linux-input@vger.kernel.org >> Cc: linux-media@vger.kernel.org >> Cc: linux-mmc@vger.kernel.org >> Cc: netdev@vger.kernel.org >> Cc: linux-pm@vger.kernel.org >> Cc: linux-remoteproc@vger.kernel.org >> Cc: linux-riscv@lists.infradead.org >> Cc: linux-serial@vger.kernel.org >> Cc: alsa-devel@alsa-project.org >> Cc: linux-spi@vger.kernel.org >> Cc: linux-usb@vger.kernel.org > >> >> --- >> .../socionext,uniphier-system-cache.yaml | 4 ++-- >> .../bindings/ata/sata_highbank.yaml | 1 + >> .../bindings/clock/canaan,k210-clk.yaml | 1 + >> .../bindings/display/brcm,bcm2711-hdmi.yaml | 1 + >> .../bindings/display/brcm,bcm2835-hdmi.yaml | 1 + >> .../display/panel/jdi,lt070me05000.yaml | 1 + >> .../display/panel/mantix,mlaf057we51-x.yaml | 3 ++- >> .../display/panel/novatek,nt36672a.yaml | 1 + >> .../devicetree/bindings/dsp/fsl,dsp.yaml | 2 +- >> .../devicetree/bindings/eeprom/at25.yaml | 3 +-- >> .../bindings/extcon/extcon-ptn5150.yaml | 2 ++ >> .../bindings/gpio/gpio-pca95xx.yaml | 1 + >> .../bindings/iio/adc/adi,ad7768-1.yaml | 2 ++ >> .../bindings/iio/adc/aspeed,ast2400-adc.yaml | 1 + >> .../bindings/iio/adc/lltc,ltc2496.yaml | 2 +- >> .../bindings/iio/adc/qcom,spmi-vadc.yaml | 1 + >> .../bindings/iio/adc/st,stm32-adc.yaml | 2 ++ >> .../iio/magnetometer/asahi-kasei,ak8975.yaml | 1 + >> .../iio/potentiometer/adi,ad5272.yaml | 1 + >> .../input/touchscreen/elan,elants_i2c.yaml | 1 + >> .../interrupt-controller/fsl,intmux.yaml | 2 +- >> .../interrupt-controller/st,stm32-exti.yaml | 2 ++ >> .../allwinner,sun4i-a10-video-engine.yaml | 1 + >> .../devicetree/bindings/media/i2c/imx219.yaml | 1 + >> .../memory-controllers/exynos-srom.yaml | 2 ++ >> .../bindings/misc/fsl,dpaa2-console.yaml | 1 + >> .../bindings/mmc/mmc-controller.yaml | 2 ++ >> .../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 1 + >> .../bindings/net/ti,k3-am654-cpts.yaml | 1 + >> .../phy/allwinner,sun4i-a10-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun50i-a64-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun50i-h6-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun5i-a13-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun6i-a31-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun8i-a23-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun8i-a83t-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun8i-h3-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun8i-r40-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun8i-v3s-usb-phy.yaml | 2 ++ >> .../phy/allwinner,sun9i-a80-usb-phy.yaml | 19 >> ++++++++----------- >> .../phy/socionext,uniphier-ahci-phy.yaml | 2 +- >> .../phy/socionext,uniphier-pcie-phy.yaml | 2 +- >> .../phy/socionext,uniphier-usb3hs-phy.yaml | 2 +- >> .../phy/socionext,uniphier-usb3ss-phy.yaml | 2 +- >> .../bindings/phy/ti,phy-gmii-sel.yaml | 2 +- >> .../pinctrl/aspeed,ast2400-pinctrl.yaml | 3 +-- >> .../pinctrl/aspeed,ast2500-pinctrl.yaml | 4 ++-- >> .../bindings/power/supply/bq25980.yaml | 1 + >> .../bindings/remoteproc/ingenic,vpu.yaml | 2 +- >> .../remoteproc/ti,omap-remoteproc.yaml | 3 +++ >> .../bindings/riscv/sifive-l2-cache.yaml | 1 + >> .../bindings/serial/renesas,hscif.yaml | 2 ++ >> .../bindings/serial/renesas,scif.yaml | 2 ++ >> .../bindings/serial/renesas,scifa.yaml | 2 ++ >> .../bindings/serial/renesas,scifb.yaml | 2 ++ >> .../sound/allwinner,sun4i-a10-codec.yaml | 1 + >> .../bindings/sound/google,sc7180-trogdor.yaml | 1 + >> .../bindings/sound/samsung,aries-wm8994.yaml | 3 +++ >> .../bindings/sound/samsung,midas-audio.yaml | 2 ++ >> .../devicetree/bindings/sound/tas2562.yaml | 2 ++ >> .../devicetree/bindings/sound/tas2770.yaml | 2 ++ >> .../bindings/sound/tlv320adcx140.yaml | 1 + >> .../devicetree/bindings/spi/renesas,rspi.yaml | 2 ++ >> .../devicetree/bindings/sram/sram.yaml | 2 ++ >> .../timer/allwinner,sun4i-a10-timer.yaml | 2 ++ >> .../bindings/timer/intel,ixp4xx-timer.yaml | 2 +- >> .../usb/allwinner,sun4i-a10-musb.yaml | 2 +- >> .../bindings/usb/brcm,usb-pinmap.yaml | 3 +++ >> .../devicetree/bindings/usb/generic-ehci.yaml | 1 + >> .../devicetree/bindings/usb/generic-ohci.yaml | 1 + >> .../devicetree/bindings/usb/ingenic,musb.yaml | 2 +- >> .../bindings/usb/renesas,usbhs.yaml | 1 + >> .../devicetree/bindings/usb/ti,j721e-usb.yaml | 3 ++- >> .../bindings/usb/ti,keystone-dwc3.yaml | 2 ++ >> 74 files changed, 118 insertions(+), 33 deletions(-) For bindings/remoteproc/ingenic,vpu.yaml and devicetree/bindings/usb/ingenic,musb.yaml: Acked-by: Paul Cercueil Cheers, -Paul