Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp464919pxu; Tue, 5 Jan 2021 16:45:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyWOyqN6Jo47gDBiB6yOctPCA5Z1+8T3pTsQ/LY+44DjMxYbYww8rdySHo7KJJ5bNKCnEu X-Received: by 2002:aa7:c58a:: with SMTP id g10mr2169617edq.315.1609893914810; Tue, 05 Jan 2021 16:45:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609893914; cv=none; d=google.com; s=arc-20160816; b=vXv147aS0YOH63mQ+ni17PhSHiEVLfJvgOI8SSUMC+nrXNEno5Si9a9SXyuy1mGfUG Ol1TA9oBVn2FkgIV/abvS59ETDEiwk5SqImqaCxZeapMILGEylZTduMEFLGQ2lxXDefT KTD+zwKrY9240k3xAWt870CPc9War4F9QxnUnoltBfWniznN7Zl1l8iT+0lAPho1+IPd LBORO0U+5KjTN7kmv3aJB72Mv5ejOFlGtxOgwpCFZnUIkbV+SLVM2VdTILdMNN8/3NcK W+2flRh5CJLqfGH38zeZ/AJsjuXqKQdcRF+CJgiGeEBg/Er05Z2O6YH3bzVCBdw8FGGh lvIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2NERpPhU2OXBhDvUAFo40ft4rRiVzLRE9qNCr5PlmPE=; b=rafRGU5B0j/d493j3DNK7BDIt3OL4DcIhx26+HzPrLKHCbVL9t2cgZw5ST+zjHCLB6 MlGcaLOMa+Fk6o4FGJdokZo3CkEPhzcTck5qCuX8OGXZaY1gfOhY5uxMd6sV2mi1kLQZ 33TK92dq4sT/oP+lJkJPF+eu/MOwLLWrG7Jyv+WCtC9Vg5xH/LeJNVfUiQWKFJ0xDjhR tZqJujpOcjnaLHfiWWjIlIO9OpVZVpKjjoStMHclJeYqrgkNjJolTMp6imM8rkiDu0di 0pnsA7Okpi3cBRP6CkkIl/juuRJsZIE0OV88e7cIAl3pzmlx7sUqpKpVVknVUGNQdte9 ktWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ITOWwX2r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hh14si294284ejb.457.2021.01.05.16.44.51; Tue, 05 Jan 2021 16:45:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ITOWwX2r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730141AbhAEWHu (ORCPT + 99 others); Tue, 5 Jan 2021 17:07:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:40092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729419AbhAEWHu (ORCPT ); Tue, 5 Jan 2021 17:07:50 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1AF8422D75; Tue, 5 Jan 2021 22:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609884429; bh=QKouQDs5mHt1pS/Y2SeBb6oJBFvZCDfzTFkJdGgVs1g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ITOWwX2rcOhhLmvDkNKzFrD2LxFRdIE0wkVUq0VDROLZxXGOSsH+fAUPM4+GQ6+vK K8z72IFnwhDIH94i/fVMzO4hM/69U7wRGS5CsnHgKPUp8rhUMT3r7m37Y1PqlGAbsi VaAx/35TIeN3xYMemCqE4xGm6NoT+mTTFTIFtpbDfseCchoft1LsuWA+jCbZwOkLGz 227YFFVlq60iGVAc97odi1HkrxwJcMdG1HojSQrAwLegNs3SurTiZTeQjtFQVDztfF vTPe+A0scAMsVwAc8O6xyiadPA60uav2BIh9B1DLcFWArEkGF4r1t6wkdzF+UUyR1a IqcFXNJkiB9Bw== From: Will Deacon To: kjlu@umn.edu, Dinghao Liu Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , Jiang Liu , iommu@lists.linux-foundation.org, David Woodhouse , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] iommu/intel: Fix memleak in intel_irq_remapping_alloc Date: Tue, 5 Jan 2021 22:07:00 +0000 Message-Id: <160987392685.28117.15806761775546828125.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210105051837.32118-1-dinghao.liu@zju.edu.cn> References: <20210105051837.32118-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Jan 2021 13:18:37 +0800, Dinghao Liu wrote: > When irq_domain_get_irq_data() or irqd_cfg() fails > at i == 0, data allocated by kzalloc() has not been > freed before returning, which leads to memleak. Applied to arm64 (for-next/iommu/fixes), thanks! [1/1] iommu/intel: Fix memleak in intel_irq_remapping_alloc https://git.kernel.org/arm64/c/ff2b46d7cff8 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev