Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 05 Jan 2021 16:00:18 -0800 (PST)
Message-Id: <20210105.160018.901800594374682376.davem@davemloft.net>
To:     fthain@telegraphics.com.au
Cc:     kuba@kernel.org, christophe.jaillet@wanadoo.fr,
        tsbogend@alpha.franken.de, chris@zankel.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 net RESEND] net/sonic: Fix some resource leaks in
 error handling paths
From:   David Miller <davem@davemloft.net>
In-Reply-To: <529006a7dcd2cd345c2261d4beae0960880f4828.1609633586.git.fthain@telegraphics.com.au>
References: <529006a7dcd2cd345c2261d4beae0960880f4828.1609633586.git.fthain@telegraphics.com.au>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

From: Finn Thain <fthain@telegraphics.com.au>
Date: Sun, 03 Jan 2021 11:26:26 +1100

> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors().
> 
> This is correctly freed in the remove function, but not in the error
> handling path of the probe function. Fix this by adding the missing
> dma_free_coherent() call.
> 
> While at it, rename a label in order to be slightly more informative.
> 
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Chris Zankel <chris@zankel.net>
> References: commit 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'")
> Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.")
> Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

Applied and queued up for -stable, thanks.