Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 05 Jan 2021 16:02:59 -0800 (PST)
Message-Id: <20210105.160259.377394842851693699.davem@davemloft.net>
To:     zhengyongjun3@huawei.com
Cc:     kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Markus.Elring@web.de
Subject: Re: [PATCH v3 net-next] net: kcm: Replace fput with sockfd_put
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20201230091809.942-1-zhengyongjun3@huawei.com>
References: <20201230091809.942-1-zhengyongjun3@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

From: Zheng Yongjun <zhengyongjun3@huawei.com>
Date: Wed, 30 Dec 2020 17:18:09 +0800

> The function sockfd_lookup uses fget on the value that is stored in
> the file field of the returned structure, so fput should ultimately be
> applied to this value.  This can be done directly, but it seems better
> to use the specific macro sockfd_put, which does the same thing.
> 
> Perform a source code refactoring by using the following semantic patch.
> 
>     // <smpl>
>     @@
>     expression s;
>     @@
> 
>        s = sockfd_lookup(...)
>        ...
>     + sockfd_put(s);
>     - fput(s->file);
>     // </smpl>
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Applied.