Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] Documentation/dax: Update description of DAX policy
 changing
To:     Ira Weiny <ira.weiny@intel.com>
CC:     <corbet@lwn.net>, <davem@davemloft.net>,
        <gregkh@linuxfoundation.org>, <alexander.deucher@amd.com>,
        <mchehab+huawei@kernel.org>, <lee.jones@linaro.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20210104024040.5381-1-lihao2018.fnst@cn.fujitsu.com>
 <20210104163653.GG3097896@iweiny-DESK2.sc.intel.com>
From:   "Li, Hao" <lihao2018.fnst@cn.fujitsu.com>
Message-ID: <1a4dc84b-56ee-bf77-cf0d-dd9e0637b90c@cn.fujitsu.com>
Date:   Wed, 6 Jan 2021 09:15:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20210104163653.GG3097896@iweiny-DESK2.sc.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 2021/1/5 0:36, Ira Weiny wrote:
> On Mon, Jan 04, 2021 at 10:40:40AM +0800, Hao Li wrote:
>> After commit 77573fa310d9 ("fs: Kill DCACHE_DONTCACHE dentry even if
>> DCACHE_REFERENCED is set"), changes to DAX policy will take effect
>> as soon as all references to this file are gone.
>>
>> Update the documentation accordingly.
>>
>> Signed-off-by: Hao Li <lihao2018.fnst@cn.fujitsu.com>
>> ---
>>  Documentation/filesystems/dax.txt | 15 ++-------------
>>  1 file changed, 2 insertions(+), 13 deletions(-)
>>
>> diff --git a/Documentation/filesystems/dax.txt b/Documentation/filesystems/dax.txt
>> index 8fdb78f3c6c9..a5af22831087 100644
>> --- a/Documentation/filesystems/dax.txt
>> +++ b/Documentation/filesystems/dax.txt
>> @@ -84,19 +84,8 @@ Summary
>>         described in 6) below.
>>  
>>   6. When changing the S_DAX policy via toggling the persistent FS_XFLAG_DAX flag,
>                                                                                   ^^
>                                                   I would delete this '.' as well.
>
>> -    the change in behaviour for existing regular files may not occur
>> -    immediately.  If the change must take effect immediately, the administrator
>> -    needs to:
>> -
>> -    a) stop the application so there are no active references to the data set
>> -       the policy change will affect
>> -
>> -    b) evict the data set from kernel caches so it will be re-instantiated when
>> -       the application is restarted. This can be achieved by:
>> -
>> -       i. drop-caches
>> -       ii. a filesystem unmount and mount cycle
>> -       iii. a system reboot
>> +    the change to existing regular file won't take effect until the file is closed
>                                                                       ^^^^^
>                                                                       files
>
>> +    by all processes or all processes referencing the file are stopped.
>
> So how about:
>
>    6. When changing the S_DAX policy via toggling the persistent FS_XFLAG_DAX
>       flag the change to existing regular files won't take effect until the file
>       is closed by all processes or all processes referencing the file are
>       stopped.
>
> I also feel like mentioning the stoppage of process' is redundant as users
> should know that will result in the closing of those FDs but I'm ok leaving it
> if others like it.

Thanks, it's much better than before.

Regards,
Hao Li

>
>
> Ira
>
>>  
>>  
>>  Details
>> --
>> 2.29.2
>>
>>
>>
>
>