Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750847AbWIHQqF (ORCPT ); Fri, 8 Sep 2006 12:46:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750891AbWIHQqF (ORCPT ); Fri, 8 Sep 2006 12:46:05 -0400 Received: from cantor.suse.de ([195.135.220.2]:41436 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1750847AbWIHQqC (ORCPT ); Fri, 8 Sep 2006 12:46:02 -0400 Date: Fri, 8 Sep 2006 09:45:51 -0700 From: Greg KH To: Dave Jones , Matt Domsch , linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.18-rc5] PCI: sort device lists breadth-first Message-ID: <20060908164551.GA491@kroah.com> References: <20060908031422.GA4549@lists.us.dell.com> <20060908155639.GJ28592@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060908155639.GJ28592@redhat.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1580 Lines: 37 On Fri, Sep 08, 2006 at 11:56:39AM -0400, Dave Jones wrote: > On Thu, Sep 07, 2006 at 10:14:22PM -0500, Matt Domsch wrote: > > Problem: > > New Dell PowerEdge servers have 2 embedded ethernet ports, which are > > labeled NIC1 and NIC2 on the chassis, in the BIOS setup screens, and > > in the printed documentation. Assuming no other add-in ethernet ports > > in the system, Linux 2.4 kernels name these eth0 and eth1 > > respectively. Many people have come to expect this naming. Linux 2.6 > > kernels name these eth1 and eth0 respectively (backwards from > > expectations). I also have reports that various Sun and HP servers > > have similar behavior. > > This came up years back when 2.6 was something new, and the answer > then was 'bind the interface to the MAC address'. It came up then? I don't recall it, if so, I hope I didn't say that... We should fix this, it's obviously a regression. Thanks a lot Matt for tracking this down and fixing it. > Whilst your patch will fix the case that's currently broken (2.4->2.6), > doesn't it offer equal possibility to break existing setups when people move > from <=2.6.18 -> 2.6.19 ? It might, but I'll take that heat, we do have a command line option that returns the functionality to the "broken" way. Let's see what happens in the next -mm. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/