Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Tyrel Datwyler <tyreld@linux.ibm.com>
Cc:     james.bottomley@hansenpartnership.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, brking@linux.ibm.com,
        Brian King <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 4/5] ibmvfc: complete commands outside the host/queue
 lock
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1v9caekxl.fsf@ca-mkp.ca.oracle.com>
References: <20201218231916.279833-5-tyreld@linux.ibm.com>
        <20210104222422.981457-1-tyreld@linux.ibm.com>
Date:   Tue, 05 Jan 2021 23:42:46 -0500
In-Reply-To: <20210104222422.981457-1-tyreld@linux.ibm.com> (Tyrel Datwyler's
        message of "Mon, 4 Jan 2021 16:24:22 -0600")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by SJ0PR13CA0219.namprd13.prod.outlook.com (2603:10b6:a03:2c1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.4 via Frontend Transport; Wed, 6 Jan 2021 04:42:47 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 75c0d038-bd96-4ede-c994-08d8b1fd84b1
X-MS-TrafficTypeDiagnostic: PH0PR10MB4438:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB4438C7892111E6C903FC47018ED00@PH0PR10MB4438.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: dnzBCC3di4oRNwB/Ik2o1LZC0qO/lSv18mgA2RkOxMHa1LwXo2tqmhmLp2k75nyxZQGX/qJRtfsttHe1sHigh+nmsde4adofU79HSQX3cLmoOeqgdYLzeoOKgOcYtVuMTHYUp11V02z2mg2fiEqtqP69VzIHj8rL9KN2V6dvCD/FzmQMPs4slEKXdBCnl1YEsjKbkcf8ed1CHlnhpw3eF2dEo3d3glbps4yB+J5Z5gxPe86+VBQ0cSNd9OpDAxGFcGunFuya02+35Xd51UrfaASfC6Q4jkNWW9jdBJ6P4987viWAXl0vYXX7OG190fb1bJN9bYBHXpLhqzbdCc24oJogZQYd7JFCG/bkWRPHinXlLTIYwdRozzpvV/BjslqnK70gnG4hSpHPcNf87pzidg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39830400003)(346002)(366004)(136003)(376002)(86362001)(66946007)(55016002)(6916009)(5660300002)(956004)(66476007)(66556008)(26005)(186003)(4326008)(16526019)(8676002)(52116002)(36916002)(2906002)(7696005)(316002)(83380400001)(478600001)(4744005)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?Es2WLdqvOb/cwA/1wg55XrlsSFQ18p7gCUmC81uty23h4SDL4arrvjSsf70K?=
 =?us-ascii?Q?aqrtRcO7c0uoU121b1xOSXZO9IyKA2zAt2ILQCdbpteS5b+sg1PwfhoRuFlX?=
 =?us-ascii?Q?draoHCYlcHJQCj5tJ7kUvy7/DemYt4XSvSzxxqPV2Afmdzmgu+fMVu7tF8O7?=
 =?us-ascii?Q?uqdosHUfnaxydAkVpCs4b47jI8HSzyX1+O+04AR3fBWGvkUt+NrfPniDzNbb?=
 =?us-ascii?Q?jrzlTodKxTyu/0BJkjElSf0tulD3vZGHyCYSe0JLL36o/ZI4ST2gmUaaYDPu?=
 =?us-ascii?Q?E2WsbcQd7YPlpX2pmdoD6BpImSlhYJ3dKaKI9ftG6cPVMMlY1C81Pq+s3+0T?=
 =?us-ascii?Q?+/3WNIR6rZbo5UvAk3xi4sjnVwhym7yNjncYI2aw4U6dV8PUJhFUBB+eZqey?=
 =?us-ascii?Q?+PEroUDzNd9879/vlHXv6rUKX/2/1hK/+YMl6nOf7QT28+ODty+Mcb7hT2C1?=
 =?us-ascii?Q?S4pZWrm3OZG2e2IytPxw02CLddI61hiNhxpLmqib04R02OcYlDoae+1xsp0D?=
 =?us-ascii?Q?tW18lZIeyIyCPvehaZxg7LSwAolg3aiApwc6lmsaDAcajXlN54M7k6RywjQA?=
 =?us-ascii?Q?LmeSoGDn9oNzGkAuhCSZSgCigXqCYM7A1AoAl91MR4NpgRZC0lSVCWeKGrrY?=
 =?us-ascii?Q?BeBw4NXZfZJ8ikIh4yxNKaZ1uj21qARNnU81Y6tDW+S+dZB6mCQbQv6c4puW?=
 =?us-ascii?Q?kJ2gPRNJv84RxEue53pKmMSWD+gu3DRUNDphNUqW+HDjIikioYKQU4E9ewuC?=
 =?us-ascii?Q?q4O7ZwT6az2VaVYVDEimeeQehsFhvgUoKhhQ/cZW8zZ/H9qnaXllbMyVUL24?=
 =?us-ascii?Q?GGLB8qtdwH270F47mcuhhxf8GyBvywEJe+vfJXYF5a6vVDzYFyTVRdgr0jcI?=
 =?us-ascii?Q?8LxJMAamMsokZEUvhth5FPxgA80txufHjS/jU2FUY+Rd0mIiurKX/VkQYKkg?=
 =?us-ascii?Q?y4HB1VdH4hvcqANN1qBurGeeOu0T+QT1sMsTyV6AyRM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2021 04:42:48.2985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-Network-Message-Id: 75c0d038-bd96-4ede-c994-08d8b1fd84b1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r4Agh16uzVf/Wpcgs8Ok5j4fbvu/eGFyb7Uniuzz8s/mL1EyVenFL8mW0pHDv5SYRG7vyI8EJyk30uS7GsuSjr1hZeOS9y13Z/pr1bO3kHQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4438
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9855 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 phishscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101060027
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9855 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 adultscore=0
 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1011 impostorscore=0
 spamscore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101060028
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Tyrel,

> Drain the command queue and place all commands on a completion list.
> Perform command completion on that list outside the host/queue locks.
> Further, move purged command compeletions outside the host_lock as well.

Please resubmit entire series instead of amending individual patches.

thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering