Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp703176pxu; Wed, 6 Jan 2021 01:57:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJww5gHMwkXFZrcHFkVk0HBerZhv+97EGup40Cc8e6Uyqfh0ISuDn7vBqkPdp1YwjQdwtGix X-Received: by 2002:a05:6402:1592:: with SMTP id c18mr3374351edv.181.1609927054322; Wed, 06 Jan 2021 01:57:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609927054; cv=none; d=google.com; s=arc-20160816; b=F81dQaEKTMMniTU7cofLLC57ZOIvgFu0r0aanSvt7mXcjMEOfRvTyMS9tEaRvEZddL bwqa5M/q8H3O+vZL6h1naV0thEraeXk7wXELGLFVkO83w8bqKmwjpEX33xbXM8yqraao 2Qlj+d8WbFNjZEgJxTdHriTkjkENbH+jV8DrbmwbjohHiIOFI++Z7UELU/7S4QvaMqK9 K1u8YLXsXjDgC/qr/q8yYa0LcEOFOAvmhWFSEitk1AzaWG0ipf8TbnHoZ4ogDbgpnOae tNxhlF3BxMtxQn2O/RgPxfqlWf2I2jPURDvOCRC59k9PkVGW3QUm/x4/j/keE37z5t9G y9hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:date:message-id:from:references:cc:to :subject; bh=O3EnlXdXH+YJZpHGbtDOTaDhKrH+b6WJFL1PXvE0tqA=; b=Qxcnd8OUmg8vJc8Lqk+5P/5cE2Vpj6tMRdr2VbyClbStfD3tnmjyk9bDPZzg4hw44y Os1lfEtjy6Kdmc0nhOZardQ7ndEtKx/EHowaiahEeIVehpWRD16Ab2+g4362RdJxHWQX QzfLkRah98wNWAJm0Y3vjv+szM3c13lGGISm4OEZ5gIdUXfy8Q/o+ECRj99LGPlR7W4p cDeusms+vsN5RB6Y2YOnmPey2O8vK9Yju/l/2ZZbNKmGh5lEAesbFlaitdFezgfqfBA0 +2HZdYTODys4LRkjCzj6NDB9u3GWDfQ5yLjKtooDH9+YSBhx2drRcvxxxn7u4riWV733 w7sA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b13si755134edw.300.2021.01.06.01.57.10; Wed, 06 Jan 2021 01:57:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbhAFJ4A (ORCPT + 99 others); Wed, 6 Jan 2021 04:56:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbhAFJz7 (ORCPT ); Wed, 6 Jan 2021 04:55:59 -0500 Received: from yawp.biot.com (yawp.biot.com [IPv6:2a01:4f8:10a:8e::fce2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94141C06134C for ; Wed, 6 Jan 2021 01:55:18 -0800 (PST) Received: from debian-spamd by yawp.biot.com with sa-checked (Exim 4.93) (envelope-from ) id 1kx5X9-00Bvk3-Ip for linux-kernel@vger.kernel.org; Wed, 06 Jan 2021 10:55:15 +0100 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on yawp X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,HELO_MISC_IP, RDNS_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.4 Received: from [85.234.217.28] (helo=[10.0.1.5]) by yawp.biot.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kx5Wp-00BvjI-AB; Wed, 06 Jan 2021 10:54:55 +0100 Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support To: Rob Herring Cc: devicetree@vger.kernel.org, John Crispin , Marc Zyngier , linux-kernel@vger.kernel.org, Birger Koblitz , Thomas Gleixner , Rob Herring References: <20210104131755.2979203-1-bert@biot.com> <20210104131755.2979203-2-bert@biot.com> <1609866288.019144.372417.nullmailer@robh.at.kernel.org> From: Bert Vermeulen Message-ID: Date: Wed, 6 Jan 2021 10:54:54 +0100 MIME-Version: 1.0 In-Reply-To: <1609866288.019144.372417.nullmailer@robh.at.kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/5/21 6:04 PM, Rob Herring wrote: > On Mon, 04 Jan 2021 14:17:54 +0100, Bert Vermeulen wrote: >> Signed-off-by: Bert Vermeulen >> --- >> .../realtek,rtl-intc.yaml | 57 +++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: I fixed the syntax error that caused this to fail. But running the test now produces some errors that are not so obvious: interrupt-controller@3000: interrupt-map: [[31, 4294967295, 2], [30, 4294967295, 1], [29, 4294967295, 5]] is too short Not sure where this comes from, but running dt-validate -v gives this: Failed validating 'minItems' in schema['properties']['interrupt-map']: {'maxItems': 24, 'minItems': 24} Where did that 24 come from? I don't even have 24 initerrupts to map :-) Another error is this: interrupt-controller@3000: 'interrupt-map-mask' is a dependency of 'interrupt-map' I can see this in your dtschema package's schemas/interrupt-controller.yaml where it's defined as a dependency, but why? I don't need that property. -- Bert Vermeulen bert@biot.com