Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp713172pxu; Wed, 6 Jan 2021 02:16:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJynyURgrQzjwosnaYplGPpinQHoPyPV/jCigHJa75RObJajt/a67INOiouq3PvWkK/FqI6P X-Received: by 2002:a17:906:98d4:: with SMTP id zd20mr2346431ejb.532.1609928215562; Wed, 06 Jan 2021 02:16:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609928215; cv=none; d=google.com; s=arc-20160816; b=IAj4QPei9Ouc0ZyR0BJfiSt2QdAGGRMF1xrDaR2p0ENkbxGugkTiLgH5QZ7dFrWHWX snzl3O9lgjxSumPRZYdVgLNIAEO1zyFScZ40BZMVHcqkMlcXUCtwA18iDr1m/du5GBE4 J+BqdOcONeGPj3v2CH4CQuBylW4z5Snk1m8KKgYB9RcZJaGmLxVIB8iy4erQOFw1Ss1N 1tKOQ8anWMAyQYPBE+b5rzPa15Uv4EsmRIqdCkNU5S/wyxKjJ3L1Q0AdcnhCMUqDRtwQ wVuzhyfuFf34Bnt4B+OZNdw305KIWvxVULdhTTQZThHi4jBZGQhQ5Uf5CyVPCznkD7mI 0yag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=eZocXSf05FOBEHxM4TLKo5dzdhxs3NeaX6GiWr2606E=; b=WN9pYQ401nnQLLWWKx+y1o3cYWeZW+8/dTJKyON66SQfchg1D3JpGkqptjNcbhwEfO 1J5CJYmJ7l0wjmhhAJgOAY1bDpXPn0syHLuZ58IcSp8WHatZedY3b5LeWi4QzRNFk20C CvDvexaue0tHScgXUK2ty4Bw5h9J9PKj9P9TRWxxYPQe6Tt8GJ8GIp7FQGCtwrq33psi rFJw2CdL+//4xYqb6KbaVRtfOW6Vug0ogDMauqbUSLhz2ZM3m2aX6apl9kF2xZKVciNp wYfr4Tk96ti4JUKOM0K1zELKU5RkWXYwqJGed19Dd+nIqQcmDprFpix6yKFDWqAaS0IB GExA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=ofEN+Fil; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b="X/BH2122"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r19si696529ejz.538.2021.01.06.02.16.30; Wed, 06 Jan 2021 02:16:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm1 header.b=ofEN+Fil; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b="X/BH2122"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726405AbhAFKPr (ORCPT + 99 others); Wed, 6 Jan 2021 05:15:47 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:58405 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbhAFKPr (ORCPT ); Wed, 6 Jan 2021 05:15:47 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 9877D61D; Wed, 6 Jan 2021 05:14:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 06 Jan 2021 05:14:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=eZocXSf05FOBEHxM4TLKo5dzdhx s3NeaX6GiWr2606E=; b=ofEN+FilW/7+tHVE3j1PP1bgqNEGMMFHSOUOcIJPMS4 eumrvqjeK6tR2V6x/RMYlimpCcfvlotA43/gaux6ANbF+9uF/pAVPLHtT97cZF5h pnWYAYuZGw2SmjVJVQlBERcQvSBG3eP4dRkh4Wv6OA8uIlYsUlQIU3GfiK3ERliF XD+sLzRmLEdkUhbkq5uc3nJ/XuAX4c6tORvk4SCblIqXWonuO6KYqS61xrn7+qEP Yq40BxqW3E9GEzbipQmB1ifL20wUj5UCasECMCSleyQUURY3ZT9TCv9ot9iGz9lp S230KWVyDM4lhLWAFCbRTxKbfIqeQerG9rM23hwZjEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=eZocXS f05FOBEHxM4TLKo5dzdhxs3NeaX6GiWr2606E=; b=X/BH2122cVQNR45UulRw7h IDFkQsko90aSPVl7GqDah9+WucgA1Vdl/sq1tY5RkWBToyzBON1hV8vf7aCxdpSt LReOlCi47n+lNKRT4yIJzpG6OvpLp9PziJ09eO08Acgcqpl2ut8sp6ykL6ckT79m NYV8T/E4thnL57jSmgpqeLauk5tnGArXkPAGujwWeyj5wkiD6juzntKDg5+gEofC oIBszdxXUvkp/4flDLe4oQL3y+qOfupvgxXkV6aCvIvjFELDGla7LqYHORinwoJx lhj/0R87qbAIiohXehuVEIIsskiCRLiIL1xa2s+hbVKETJEc6hUL0pzyQAC1mrtA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdefledgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepffetteevieejteeuhfffgeektefghfeileehhedtuddutefhhfejtddvtddu ledvnecuffhomhgrihhnpeguvghvihgtvghtrhgvvgdrohhrghenucfkphepledtrdekle drieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id E4FDD108005C; Wed, 6 Jan 2021 05:14:38 -0500 (EST) Date: Wed, 6 Jan 2021 11:14:36 +0100 From: Maxime Ripard To: Rob Herring Cc: Wilken Gottwalt , "linux-kernel@vger.kernel.org" , Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang , Chen-Yu Tsai , Jernej Skrabec Subject: Re: [PATCH v5 1/2] dt-bindings: hwlock: add sun6i_hwspinlock Message-ID: <20210106101436.nrjlgaxsllvotxq3@gilmour> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="55y3zjhj665bhz2v" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --55y3zjhj665bhz2v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Dec 23, 2020 at 03:49:19PM -0700, Rob Herring wrote: > On Wed, Dec 23, 2020 at 4:34 AM Wilken Gottwalt > wrote: > > > > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i > > compatible SoCs. >=20 > Please resend to DT list so that automated checks run and it's in my > queue (PW). You need to run 'make dt_binding_check' as there are > several issues. >=20 > > Signed-off-by: Wilken Gottwalt > > --- > > Changes in v5: > > - changed binding to earliest known supported SoC sun6i-a31 > > - dropped unnecessary entries > > > > Changes in v4: > > - changed binding to sun8i-a33-hwpinlock > > - added changes suggested by Maxime Ripard > > > > Changes in v3: > > - changed symbols from sunxi to sun8i > > > > Changes in v2: > > - fixed memory ranges > > --- > > .../bindings/hwlock/sun6i-a31-hwspinlock.yaml | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwlock/sun6i-a31-= hwspinlock.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwlock/sun6i-a31-hwspinl= ock.yaml b/Documentation/devicetree/bindings/hwlock/sun6i-a31-hwspinlock.ya= ml > > new file mode 100644 > > index 000000000000..481c5c995ad7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwlock/sun6i-a31-hwspinlock.yaml > > @@ -0,0 +1,44 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/hwlock/sun6i-hwspinlock.yaml# >=20 > This will fail checks. Wrong filename. Also, the name should be the whole compatible, so "allwinner,sun6i-a31-hwspinlock.yaml". > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SUN6I hardware spinlock driver for Allwinner sun6i compatible S= oCs > > + > > +maintainers: > > + - Wilken Gottwalt > > + > > +description: > > + The hardware unit provides semaphores between the ARM cores and the = embedded > > + companion core on the SoC. > > + > > +properties: > > + compatible: > > + const: allwinner,sun6i-a31-hwspinlock > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + resets: > > + maxItems: 1 And this is not indented properly, it should be at the same level than compatible, not under it. Doesn't the meta-schema catch this? Maxime --55y3zjhj665bhz2v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX/WNjAAKCRDj7w1vZxhR xa9pAQDmGKSAO7IBtgAVPY1Oxq3TFVWFbqh7Dv74oZibv5XAYAD+IRUgYXb02O3S JHIIqrAWoj0FGZNtBaEVRo5GKp+HWA4= =ZRTb -----END PGP SIGNATURE----- --55y3zjhj665bhz2v--