Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 6 Jan 2021 11:37:25 +0100
From:   Ralf Schlatterbeck <rsc@runtux.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Willy Tarreau <w@1wt.eu>, Lars Poeschel <poeschel@lemonage.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [PATCH 1/2] auxdisplay: HD44780 connected to I2C via PCF8574
Message-ID: <20210106103725.vlqsmlxmqkjbyrzu@runtux.com>
References: <20210105150124.dvlochv3qrp4wpre@runtux.com>
 <20210105150400.j7hhxu5uextga5mz@runtux.com>
 <CANiq72mYUVvyJuv6pxeYvzQrOyRvp4Uy8AxF_WMDgQaKBndi-A@mail.gmail.com>
 <CAMuHMdXTNXmKacw47zBxG3YG_xcjMQrKS-4iy518wU+6dq9ahA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuHMdXTNXmKacw47zBxG3YG_xcjMQrKS-4iy518wU+6dq9ahA@mail.gmail.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

Miguel, Geert, thanks for the quick feedback.

On Wed, Jan 06, 2021 at 09:03:13AM +0100, Geert Uytterhoeven wrote:
> 
> Unless I'm missing some little detail, there should be no need for this
> driver: this wiring (and alternative wirings) can just be expressed in DT.
> Examples (using 74HC595 SPI GPIO expanders) can be found in my
> renesas-overlays branch:

Thanks for the examples.
I've tried this and it really works!
It feels somewhat slower (I'm using user-defined characters) but that
probably doesn't warrant its own driver.

So I'll contribute a documentation change that adds an example of how
to use the I2C-enabled version of the display, this may be non-obvious
to others. I'll start a new thread for this, stay tuned...

@Miguel: Thanks for your detailed feedback on coding style, I'll use
this next time ;-)

Ralf
-- 
Ralf Schlatterbeck                      Tel:   +43/2243/26465-16
Open Source Consulting                  www:   www.runtux.com
Reichergasse 131, A-3411 Weidling       email: office@runtux.com