Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210104131755.2979203-1-bert@biot.com> <20210104131755.2979203-2-bert@biot.com>
 <1609866288.019144.372417.nullmailer@robh.at.kernel.org> <f5333394-8141-64ed-de30-d3b095ef579e@biot.com>
In-Reply-To: <f5333394-8141-64ed-de30-d3b095ef579e@biot.com>
From:   Rob Herring <robh@kernel.org>
Date:   Wed, 6 Jan 2021 08:19:30 -0700
Message-ID: <CAL_Jsq+o+27V9DzDnShpWt+oLz38qF+a8a8eMi-qKr+nqJWSxw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: Add Realtek
 RTL838x/RTL839x support
To:     Bert Vermeulen <bert@biot.com>
Cc:     devicetree@vger.kernel.org, John Crispin <john@phrozen.org>,
        Marc Zyngier <maz@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Birger Koblitz <mail@birger-koblitz.de>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 6, 2021 at 2:55 AM Bert Vermeulen <bert@biot.com> wrote:
>
> On 1/5/21 6:04 PM, Rob Herring wrote:
> > On Mon, 04 Jan 2021 14:17:54 +0100, Bert Vermeulen wrote:
> >> Signed-off-by: Bert Vermeulen <bert@biot.com>
> >> ---
> >>  .../realtek,rtl-intc.yaml                     | 57 +++++++++++++++++++
> >>  1 file changed, 57 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
>
> I fixed the syntax error that caused this to fail. But running the test now
> produces some errors that are not so obvious:
>
>    interrupt-controller@3000: interrupt-map: [[31, 4294967295, 2], [30,
> 4294967295, 1], [29, 4294967295, 5]] is too short
>
> Not sure where this comes from, but running dt-validate -v gives this:
>
>    Failed validating 'minItems' in schema['properties']['interrupt-map']:
>      {'maxItems': 24, 'minItems': 24}
>
> Where did that 24 come from? I don't even have 24 initerrupts to map :-)

If you don't define minItems, then the default is the same as
maxItems. So you need to set 'minItems'.

>
> Another error is this:
>
>    interrupt-controller@3000: 'interrupt-map-mask' is a dependency of
> 'interrupt-map'
>
> I can see this in your dtschema package's schemas/interrupt-controller.yaml
> where it's defined as a dependency, but why? I don't need that property.

This should be the other way around. I'll fix it.

Rob