Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 6 Jan 2021 15:27:07 +0000
From:   Russell King - ARM Linux admin <linux@armlinux.org.uk>
To:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Thomas Schreiber <tschreibe@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and
 RTL9601C chips
Message-ID: <20210106152707.GO1605@shell.armlinux.org.uk>
References: <20201231121410.2xlxtyqjelrlysd2@pali>
 <X+3ume1+wz8HXHEf@lunn.ch>
 <20201231170039.zkoa6mij3q3gt7c6@pali>
 <X+4GwpFnJ0Asq/Yj@lunn.ch>
 <20210102014955.2xv27xla65eeqyzz@pali>
 <CALQZrspktLr3SfVRhBrVK2zhjFzJMm9tQjWXU_07zjwJytk7Cg@mail.gmail.com>
 <20210103024132.fpvjumilazrxiuzj@pali>
 <20210106145532.xynhoufpfyzmurd5@pali>
 <20210106152138.GK1551@shell.armlinux.org.uk>
 <20210106152338.GN1605@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210106152338.GN1605@shell.armlinux.org.uk>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Precedence: bulk

On Wed, Jan 06, 2021 at 03:23:38PM +0000, Russell King - ARM Linux admin wrote:
> On Wed, Jan 06, 2021 at 03:21:38PM +0000, Russell King - ARM Linux admin wrote:
> > On Wed, Jan 06, 2021 at 03:55:32PM +0100, Pali Roh?r wrote:
> > > On my tested CarlitoxxPro module is:
> > > 
> > >         Option values                             : 0x00 0x1c
> > >         Option                                    : RX_LOS implemented, inverted
> > >         Option                                    : TX_FAULT implemented
> > >         Option                                    : TX_DISABLE implemented
> > > 
> > > When cable is disconnected then in EEPROM at position 0x16e is value
> > > 0x82. If I call 'ip link set eth1 up' then value changes to 0x02, module
> > > itself has a link and I can connect to its internal telnet/webserver to
> > > configure it.
> > 
> > Bit 7 reflects the TX_DISABLE pin state. Bit 1 reflects the RX_LOS pin
> > state. It isn't specified whether the inverted/non-inverted state is
> > reflected in bit 1 or not - the definition just says that bit 1 is
> > "Digital state of the RX_LOS Output Pin."
> > 
> > > I also tested UBNT module and result is:
> > > 
> > >         Option values                             : 0x00 0x06
> > >         Option                                    : RX_LOS implemented
> > >         Option                                    : RX_LOS implemented, inverted
> > > 
> > > Which means that those bits are not implemented.
> > > 
> > > Anyway I check position 0x16e and value on its value is randomly either
> > > 0x79 or 0xff independently of the state of the GPON module.
> > > 
> > > So it is really not implemented on UBNT.
> > 
> > There are enhanced options at offset 93 which tell you which of the
> > offset 110 signals are implemented.
> 
> That's the ID EEPROM (A0) offset 93 for the Diagnostic address (A2)
> offset 110.

Looking at the EEPROM dumps you've sent me... the VSOL V2801F has
0xe0 at offset 93, meaning TX_DISABLE and TX_FAULT soft signals
(which is basically offset 110) are implemented, RX_LOS is not. No
soft signals are implemented on the Ubiquiti module.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!