Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 6 Jan 2021 16:15:03 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Vitaly Kuznetsov <vkuznets@redhat.com>
Cc:     Wei Liu <wei.liu@kernel.org>,
        Sunil Muthuswamy <sunilmut@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Matheus Castello <matheus@castello.eng.br>,
        KY Srinivasan <kys@microsoft.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <liuwe@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Tianyu Lan <Tianyu.Lan@microsoft.com>
Subject: Re: [PATCH v2] x86/Hyper-V: Support for free page reporting
Message-ID: <20210106161503.datosn5uopcz2lwi@liuwe-devbox-debian-v2>
References: <SN4PR2101MB08800F9A2F6961A05DAEAE4BC0D19@SN4PR2101MB0880.namprd21.prod.outlook.com>
 <87v9cagpor.fsf@vitty.brq.redhat.com>
 <20210106153523.nbnrkp4papebxqwy@liuwe-devbox-debian-v2>
 <87pn2igi2h.fsf@vitty.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pn2igi2h.fsf@vitty.brq.redhat.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Wed, Jan 06, 2021 at 05:12:54PM +0100, Vitaly Kuznetsov wrote:
> Wei Liu <wei.liu@kernel.org> writes:
> 
> > On Wed, Jan 06, 2021 at 02:28:20PM +0100, Vitaly Kuznetsov wrote:
> > [...]
> >> 
> >> > +bool hv_query_ext_cap(u64 cap_query)
> >> > +{
> >> > +	u64 *cap;
> >> > +	unsigned long flags;
> >> > +	u64 ext_cap = 0;
> >> > +
> >> > +	/*
> >> > +	 * Querying extended capabilities is an extended hypercall. Check if the
> >> > +	 * partition supports extended hypercall, first.
> >> > +	 */
> >> > +	if (!(ms_hyperv.priv_high & HV_ENABLE_EXTENDED_HYPERCALLS))
> >> > +		return 0;
> >> > +
> >> > +	/*
> >> > +	 * Repurpose the input page arg to accept output from Hyper-V for
> >> > +	 * now because this is the only call that needs output from the
> >> > +	 * hypervisor. It should be fixed properly by introducing an
> >> > +	 * output arg once we have more places that require output.
> >> > +	 */
> >> 
> >> I remember there was a patch from Wei (realter to running Linux as root
> >> partition) doing the job, we can probably merge it early to avoid this
> >> re-purposing.
> >> 
> >
> > We want to be frugal regarding memory usage, so in my patch the output
> > page is only allocated when Linux is running as the root partition.
> >
> > This patch is mostly only useful when Linux is running as a child
> > partition. This is a different use case.
> 
> Well, yea, while one 4k page per CPU is probably not much, why
> allocating something we don't really need? The whole 're-purposing' idea
> comes from the misleading 'hyperv_pcpu_input_arg' name, which can be
> just 'hyperv_pcpu_arg' (and we can allocate two pages for root
> partition).

Yes. We can simply renamed it in the future.

Wei.

> 
> All this is not a big deal, we can take a look again after root
> partition support lands and do some cleanup if needed.
> 
> -- 
> Vitaly
>