Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 6 Jan 2021 16:19:33 +0000
From:   Chris Down <chris@chrisdown.name>
To:     Hugh Dickins <hughd@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, Hui Su <sh_def@163.com>,
        Alex Shi <alex.shi@linux.alibaba.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Michal Hocko <mhocko@suse.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Shakeel Butt <shakeelb@google.com>,
        Roman Gushchin <guro@fb.org>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()
Message-ID: <X/XjFfDV7tllAqAd@chrisdown.name>
References: <alpine.LSU.2.11.2101032056260.1093@eggly.anvils>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.11.2101032056260.1093@eggly.anvils>
User-Agent: Mutt/2.0.3 (a51f058f) (2020-12-04)
Precedence: bulk

Hugh Dickins writes:
>Boot a CONFIG_MEMCG=y kernel with "cgroup_disabled=memory" and you are
>met by a series of warnings from the VM_WARN_ON_ONCE_PAGE(!memcg, page)
>recently added to the inline mem_cgroup_page_lruvec().
>
>An earlier attempt to place that warning, in mem_cgroup_lruvec(), had
>been careful to do so after weeding out the mem_cgroup_disabled() case;
>but was itself invalid because of the mem_cgroup_lruvec(NULL, pgdat) in
>clear_pgdat_congested() and age_active_anon().
>
>Warning in mem_cgroup_page_lruvec() was once useful in detecting a KSM
>charge bug, so may be worth keeping: but skip if mem_cgroup_disabled().
>
>Fixes: 9a1ac2288cf1 ("mm/memcontrol:rewrite mem_cgroup_page_lruvec()")
>Signed-off-by: Hugh Dickins <hughd@google.com>

Thanks.

Acked-by: Chris Down <chris@chrisdown.name>