Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201211222448.2115188-1-dianders@chromium.org> <20201211142412.v8.4.If41b7d621633b94d56653c6d53f5f89c5274de7b@changeid>
In-Reply-To: <20201211142412.v8.4.If41b7d621633b94d56653c6d53f5f89c5274de7b@changeid>
From:   Doug Anderson <dianders@chromium.org>
Date:   Wed, 6 Jan 2021 08:44:05 -0800
Message-ID: <CAD=FV=Wn2kBP-jL9g52ZQ_nHRi-BWwuW_oxs8CUv-k=6QcBFDA@mail.gmail.com>
Subject: Re: [PATCH v8 4/4] HID: i2c-hid: Introduce goodix-i2c-hid using
 i2c-hid core
To:     Jiri Kosina <jkosina@suse.cz>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Rob Herring <robh+dt@kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Andrea Borgia <andrea@borgia.bo.it>,
        Jiri Kosina <jikos@kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Fri, Dec 11, 2020 at 2:25 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> +static const struct goodix_i2c_hid_timing_data goodix_gt7375p_timing_data = {
> +       .post_power_delay_ms = 10,
> +       .post_gpio_reset_delay_ms = 120,

As I've been going through my holiday email I found that Goodix has
released a new datasheet (datasheet rev 0.6 from 2020-12-11) where
this moves from 120 ms to 180 ms.  Sigh.

I'm hoping that we can just land it with the 120 though and then I'll
send a follow-up patch to change to 180.  This will avoid spamming
everyone with a v9 of the patch series.  Please yell if there are any
objections to that plan.  I'd also be fine if you wanted to just
change it to 180 when landing it.

Thanks much!

-Doug