Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bc65667903652a67f17b6b51a37a03f73309fe39.camel@archlinux.org>
Subject: Re: [PATCH] HID: logitech-hidpp: add support for Unified Battery
 (1004) feature
From:   Filipe =?ISO-8859-1?Q?La=EDns?= <lains@archlinux.org>
To:     Bastien Nocera <hadess@hadess.net>, Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <0de99cc89a3cc0cc5b3818e10aefdd2eaddd8032.camel@hadess.net>
References: <20210104182937.1472673-1-lains@archlinux.org>
         <0de99cc89a3cc0cc5b3818e10aefdd2eaddd8032.camel@hadess.net>
Organization: Archlinux
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-yLAb8pRaIDV8Q/6yXyus"
Date:   Wed, 06 Jan 2021 18:48:27 +0000
MIME-Version: 1.0
User-Agent: Evolution 3.38.2 
Precedence: bulk


--=-yLAb8pRaIDV8Q/6yXyus
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2021-01-06 at 10:34 +0100, Bastien Nocera wrote:
> On Mon, 2021-01-04 at 18:29 +0000, lains@archlinux.org=C2=A0wrote:
> > From: Filipe La=C3=ADns <lains@archlinux.org>
> >=20
> > This new feature present in new devices replaces the old Battery
> > Level
> > Status (0x1000) feature. It keeps essentially the same information
> > for
> > levels (reporting critical, low, good and full) but makes these
> > levels
> > optional, the device exports a capability setting which describes
> > which
> > levels it supports. In addition to this, there is an optional
> > state_of_charge paramenter that exports the battery percentage.
> >=20
> > This patch adds support for this new feature. There were some
> > implementation choices, as described below and in the code.
> >=20
> > If the device supports the state_of_charge parameter, we will just
> > export the battery percentage and not the levels, which the device
> > might
> > still support.
>=20
> I'm guessing that means no changes needed on the upower side?
>=20
> Cheers
>=20

Yes :)
I tested upower and all works as expected.

There will still be devices that only support battery voltage, so I might
implement the battery voltage to charge percentage in a future patch.

Cheers,
Filipe La=C3=ADns

--=-yLAb8pRaIDV8Q/6yXyus
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0jW0leqs33gyftiw+JPGdIFqqV0FAl/2BfQACgkQ+JPGdIFq
qV0T2Q//aB2LBSk1ESOi7PCTzNvICgrH1kqbrYR3nIYz8hL69x8ac4qlO/Spva8Z
jDgmGI46i24Ll9YZkzovbTy/7pjTL1eSWfJnNnaGERfKEZyxU/tUO4QPPqt4/Lco
aCRgtnNYGyQyo0/TwKZqu9bLdyMBppTh8QHjnx4sGMZdqiShBuDvexHuyF7Txqee
jMpx8ZOOvhxFL6lOSd5/Dumq2W0N8tmOHd6aZEQFRF+cloJsMh6kFHRCj0wm+RGQ
w4RlogqzN1UdxUXZMGz9CSaFthHLT5W7HOcmco1artgSvOxvJdTyKIQVpfS+k0Hg
InOlNFOn0ImQ2eGQXaGyVdkOoBEsUTK4swyQSpNTTbv5unzpp3EFilE4LYqyRMWB
D3Rm7tHm86d0fPYGMtLts8rx6HzujDDKzYeqgEfP4LvjN68BUcq9oOvX7v0L7C15
r1yPoE0NGjZPu1aJX+NnDfYIOYYCf5/559usYTXQDbKjFsmptusEFpln/TRk83we
ssxEGYrImz3Y+0qvTvFyYSLctNe8kkI3StzuiRAj0VRuCa86fAWy+qL31ArOs+Qb
Wmz4KM06uGhgi+p+mCW5TGgK4osLgtUKG4LXt48wi4lwOeszypU6attIJzG5xJhO
lzywMpKmJ6Cl7X80pR2q1JrCSQNLFrsF4AqFEwFhrAiLdoycf80=
=Ccag
-----END PGP SIGNATURE-----

--=-yLAb8pRaIDV8Q/6yXyus--