Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1370f0590b09509ccf6a2c1233bbf6e96479c846.camel@gmail.com>
Subject: Re: (hid-logitech) Support for non-DJ receivers
From:   Filipe =?ISO-8859-1?Q?La=EDns?= <filipe.lains@gmail.com>
To:     Hans de Goede <hdegoede@redhat.com>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <308ef1e5-16ae-899f-9d89-d63f854b12bc@redhat.com>
References: <4990836470c5fb01babcf416ca6ccf9e5e21d152.camel@gmail.com>
         <308ef1e5-16ae-899f-9d89-d63f854b12bc@redhat.com>
Organization: Archlinux
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-mGDVV4QR84OAYbHbHAUK"
Date:   Wed, 06 Jan 2021 19:20:44 +0000
MIME-Version: 1.0
User-Agent: Evolution 3.38.2 
Precedence: bulk


--=-mGDVV4QR84OAYbHbHAUK
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2021-01-06 at 20:16 +0100, Hans de Goede wrote:
> Hi Filipe,
>=20
> hid-logitech-dj already supports exposing devices behind a non-DJ / non-
> unifying
> receiver as separate HID child-devices of the receiver as we doe for DJ
> devices.
>=20
> ATM hid-logitech-dj does not yet support the c541 PID receiver, but with =
some
> luck that could be as simple as adding this patch to the kernel:
>=20
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.=
c
> index 1ffcfc9a1e03..ee7051f3c926 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1877,6 +1877,10 @@ static const struct hid_device_id logi_dj_receiver=
s[] =3D
> {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(USB=
_VENDOR_ID_LOGITECH,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0USB_DEVICE_ID_LOGITECH_NANO_RECEIVER_LIGHTSPEED_1_1=
),
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .driver_data =3D recvr_t=
ype_gaming_hidpp},
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ /* Logitech lightspeed recei=
ver (0xc541) */
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(USB_VEND=
OR_ID_LOGITECH,
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A00xc541),
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .driver_data =3D recvr_type_g=
aming_hidpp},
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ /* Logitech 27 MHz HID+=
+ 1.0 receiver (0xc513) */
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(USB=
_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_MX3000_RECEIVER),
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .driver_data =3D recvr_t=
ype_27mhz},
>=20
> Where the second 0xc541 should really be a
> USB_DEVICE_ID_LOGITECH_NANO_RECEIVER_LIGHTSPEED_1_2 define in hid-ids.h, =
but
> we
> can fix that when upstreaming this.
>=20
> For now if you can get the reporter of the bug to build a kernel with the
> above change and test that, then that would be great. If things do not wo=
rk
> OOTB with this change, then we may need to do some additional work on
> the kernel side, but we do already support lightspeed receivers, so
> we should be able to add support for this new model too.
>=20
> Regards,
>=20
> Hans
>=20
> [1] https://github.com/libratbag/libratbag/pull/1071
>=20
>=20
>=20

Great to know!

I have that device, I can try it out and send a patch if everything is work=
ing
correctly :)

The lightspeed receivers we support all have the DJ interface, these new on=
es do
not. But yeah, I think it should just work, or at least be simple to make i=
t
work.

Cheers,
Filipe La=C3=ADns

--=-mGDVV4QR84OAYbHbHAUK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0jW0leqs33gyftiw+JPGdIFqqV0FAl/2DYwACgkQ+JPGdIFq
qV1nIRAApmYeDXt6Ct9zsX9m+4gz4kL+zDy7I8cBgjt4Yb5WmZYNTkKSb8xS8mf4
hGeusY2XXFSwDFLCgsJujff59UBmyO6p0x2D4nSiOMtAezOlDa6ZpiLv+TFMYEUp
RCMykhQXjWrg2ndx6lvKlIjULFbdixg/zQi1XniZUKllBMYSFi0f6jRWjNRJW6of
fSrpBBq+zLxD6Ro90Ed+/S+N2GMhUckNCtmQUhS0AfkF91LEwnGex2yl4Gfqlv7I
fy5Z5FgFut0kl+7ujLhKVj5gkbjqBdqUMyNTvTGpD/RK7BfJFj6woVMWWLDXeAmO
7KIcQBSd/lfyBfLG9eHNf2msAMx4EaZbOUjaJOPfGaH6nzUdpaV1lzDGa1591XdI
mdNCYxSFq5ocIiuXDxu7sN6quqJu5eK2PAPuysJtkxgdkLLosX4GfKmGhMR4vJq8
NMj17/XdBri2vFfQ/SHu54b5mxWXjogFHJYvD7gmi4TXLKdsl1LGVPv/6SvjTvuj
z4uAQJeDYajl1aII2LKefJB4U0rNdcFawkbYcT4AGmMaF559zfFCgGwhdi859CUc
7jWNjo5PZ2anmHz7YREP9atTq+OuC4ZJfpeTW2A1a1YH1YfdVTocag5gWufHbZCA
pZL1OcUwrhLdnJT0u9f3p3hB/XobzwJ8YlQZrfmlihgOv4rdU/s=
=VYvi
-----END PGP SIGNATURE-----

--=-mGDVV4QR84OAYbHbHAUK--