Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 5mE3/KKfnb5jJoUfG7NTSrF7Sp5cG8tg9Zg6AgkLW/rZP1xffntEwDycykiIXnT4hHmrqRmPsk
 fVAFiU6mRWag==
IronPort-SDR: YEJZpd+GdDGfRwXE0dE66Ugo8WQA/GWfXTYg8joXm9QElso2h2aWOr5731RpvZEjhP1S+V+3wr
 rz+WqU3Bw8fA==
From:   "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
To:     Benson Leung <bleung@google.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
        "pmalani@chromium.org" <pmalani@chromium.org>,
        "bleung@chromium.org" <bleung@chromium.org>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "Mani, Rajmohan" <rajmohan.mani@intel.com>
Subject: RE: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux
 configuration acknowledgment to EC
Thread-Topic: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux
 configuration acknowledgment to EC
Thread-Index: AQHWzrsx4jhzkeZK+Ee8qthNzOpyP6oZzOWAgABHFHA=
Date:   Wed, 6 Jan 2021 21:17:58 +0000
Message-ID: <MWHPR11MB0048066CBB95E3C1CBBDD41EA9D00@MWHPR11MB0048.namprd11.prod.outlook.com>
References: <20201210060903.2205-1-utkarsh.h.patel@intel.com>
 <20201210060903.2205-3-utkarsh.h.patel@intel.com>
 <X/TtO/HbYAKhznhg@google.com>
In-Reply-To: <X/TtO/HbYAKhznhg@google.com>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a67b04db-dca8-4870-bc2f-08d8b2888afc
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2021 21:17:58.9191
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Mjgtr3vBVHQDy7PbvS21eJqbE2S4DK4j8S4zU+i1dd9pWNzNjR3ZIPyLVRsHygmfROQFdpFnpm2dicu5oMea3dVTDSLAuEh9AFm4dld16WY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2191
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Benson,

Thank you for applying the patches.

> -----Original Message-----
> From: Benson Leung <bleung@google.com>
> Sent: Tuesday, January 05, 2021 2:51 PM
> To: Patel, Utkarsh H <utkarsh.h.patel@intel.com>
> Cc: linux-kernel@vger.kernel.org; enric.balletbo@collabora.com;
> pmalani@chromium.org; bleung@chromium.org;
> heikki.krogerus@linux.intel.com; Mani, Rajmohan
> <rajmohan.mani@intel.com>
> Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux
> configuration acknowledgment to EC
>=20
> Hi Utkarsh,
>=20
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c
> > b/drivers/platform/chrome/cros_ec_typec.c
> > index 650aa5332055..e6abe205890c 100644
>=20
> I went ahead and staged this commit, but just for your information, apply=
ing
> this patch was problematic because the sha1 used here didn't match anythi=
ng
> in the upstream kernel.
>=20
> Here's the error when I try to apply this using git am:
> Applying: platform/chrome: cros_ec_typec: Send mux configuration
> acknowledgment to EC
> error: sha1 information is lacking or useless
> (drivers/platform/chrome/cros_ec_typec.c).
> error: could not build fake ancestor
> Patch failed at 0001 platform/chrome: cros_ec_typec: Send mux configurati=
on
> acknowledgment to EC
>=20
>=20
> Please double check when you run git-format-patch that the branch you are
> working on comes from publicly available git repos, ideally, based on lin=
us's
> tagged releases. This will ensure things apply cleanly on my side.

Sorry about this. I think I might have used for-next branch mistakenly when=
 running git-format-patch.
I will make sure to use correct one next time.=20

>=20
> I've gone ahead and staged this, but could you please sanity check that t=
he
> result is as intended?
>=20
> https://git.kernel.org/pub/scm/linux/kernel/git/chrome-
> platform/linux.git/commit/?h=3Dcros-ec-typec-for-
> 5.12&id=3D8553a979fcd03448a4096c7d431b7ee1a52bfca3

I have checked it on myside and works as intended.

>=20
> Thank you,
> Benson
>=20

Sincerely,
Utkarsh Patel.=20