Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ARC: unbork 5.11 bootup: fix snafu in _TIF_NOTIFY_SIGNAL
 handling
To:     Vineet Gupta <Vineet.Gupta1@synopsys.com>,
        linux-snps-arc@lists.infradead.org
Cc:     linux-kernel@vger.kernel.org
References: <20210107001225.3063163-1-vgupta@synopsys.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <0c62fbca-87e1-f53a-26e1-35244e2e6f48@kernel.dk>
Date:   Wed, 6 Jan 2021 19:13:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210107001225.3063163-1-vgupta@synopsys.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/6/21 5:12 PM, Vineet Gupta wrote:
> Linux 5.11.rcX was failing to boot on ARC HSDK board. Turns out we have
> a couple of issues, this being the first one, and I'm to blame as I
> didn't pay attention during review.
> 
> TIF_NOTIFY_SIGNAL support requires checking multiple TIF_* bits in
> kernel return code path. Old code only needed to check a single bit so
> BBIT0 <TIF_SIGPENDING> worked. New code needs to check multiple bits so
> AND <bit-mask> instruction. So needs to use bit mask variant _TIF_SIGPENDING

Sorry about that, my arc asm isn't that strong :-)
Thanks for fixing it.

-- 
Jens Axboe