Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp178929pxu; Thu, 7 Jan 2021 01:46:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJycU0tm8TgyXycO81syP9V3NpcZyKe6b2RHMcxX1AhnkzUhVUmoHs57bERKmWi+fefN3OKU X-Received: by 2002:a17:906:59a:: with SMTP id 26mr5579334ejn.309.1610012804621; Thu, 07 Jan 2021 01:46:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610012804; cv=none; d=google.com; s=arc-20160816; b=mJlS9USTYXVfZ6ujFUsESV4wlwPQ2S4zCCggPFCh+VX7VosOBkMuNVgpgCU+QckQhj X/18Ee84ZF2CYtxMfI/KMkhO+rqDVm9ck+yZAHhGfVR0Qmgz2RTwtJOrsoX+FK8v6UeM H/7Mr58di7fKjkx6xdF+COdMrmvydjeVMqJITSbS8voj+s1ztKLVDOMpZsGunOHMO97p dB3KdmTv9muqzae9taZBX7Nnk/k3uRzMXh08PxI3BnC97hytWuMLEmV7B4zDq1J9OhaJ 5EQBgNqN9TRI8bWZI4QydmrETM7EwDaQnjATSFI1PIU7IcZbjIhbu4B+qzzT7DmAD/aF VrIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=/gkZ6YBZc1TuDyrVRGbq/7fN83HRpfdis1YYIT6DC+Q=; b=wGJ2qPiVlKILsEnibQIUAQXDrIhYKnHKe8sqKwQNJUR1GR/FxL1F3BPAM8OjxsumKa clVWm6BeeL64E9UVVxsmPRdUO26QuXvEXOPedNZTZ39d8fFXmJLDoRWEee3Fx6DBkacS KzR0sEveQ/EWsvhKsgv28IhgqfOE8MVNWZYWykcCdTphl3kno+IrIunxX3J18BDsGBGm wNh+hrbqvo/B2TYH8DnkmAsxSj979WTmeyR/gsMo5XkmmCdat8veZ7diGds32QhfyPss TMaC4HeaZMkazJPLzOOXj4tq5mL8wyxrfrY7PYekPK2k1q1hVH57qpUYbwfknKGDFWbY xVgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=XUX0BcoI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si2079612eji.498.2021.01.07.01.46.20; Thu, 07 Jan 2021 01:46:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=XUX0BcoI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727252AbhAGJpq (ORCPT + 99 others); Thu, 7 Jan 2021 04:45:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbhAGJpq (ORCPT ); Thu, 7 Jan 2021 04:45:46 -0500 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D51AC0612F4 for ; Thu, 7 Jan 2021 01:45:06 -0800 (PST) Received: by mail-qk1-x732.google.com with SMTP id v126so4920375qkd.11 for ; Thu, 07 Jan 2021 01:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/gkZ6YBZc1TuDyrVRGbq/7fN83HRpfdis1YYIT6DC+Q=; b=XUX0BcoIa1MQ2jcMuATtV/lSqagHaVmb173j0UE8FAksPf0cENNwe06K9x9EyN/xij wf5RagTSVuw+GTnkcCTqtPvMabsfRvVjmCblHL9xl1iv3k3Yhy+cmQxf+Ro5otZvpM0h yfRsRQQef8iiX6B8LfBZ0/X6+3fYSnEqL6Q1MSg2dC7xiDynol+1c8zX5M+3V7XOGgp/ 5D8odmrKLEh0A+3UrF7oHzdKoJf/I5P+FIk4c4lAyP181Ce6ILIpCJCoz5GWjXbaQDKL G8/1e8OTsvfCUkYB8Kc1hJKbqHMMlBBh80re0nX73tg11ilb1hcDg+V6RYIC3WWHEGl2 lCfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/gkZ6YBZc1TuDyrVRGbq/7fN83HRpfdis1YYIT6DC+Q=; b=XgbuF0qQLRNub7fRMIerr5wqoI04+qMhjYPNGz+Xx0zCNrwDJ6+4/bRwY+SiQZ7NkB GMGHgpYkv0ndH+0pGcIcHNVsF0z8IABXZPmw2gn4zH3vn2hFOjiDXBTyRLIKXMdKMahw diQCd8plY+gp/v8wzuCmjMqB8ZVe+6NF1Sn3h5Im0s5T5upOSR3Akn1/F239/eUvmjxo oR9t45HNH7RzjR031g8Fp2YEnjBSgssU9Vor7Eph8ipSvWNC5ysoF+NH16fZqyI9hooe +oxUqSIC4l/lfwNzu7n/+i9F4a//ofgsNi4HOL542ItaZBcXdox4hdjpaPPzLJyDeOqO F8EQ== X-Gm-Message-State: AOAM531wDCNZXc1TgTSaA1R5m+jBrGm+Ct913iHBCO9EyvsClkdFEqvj g4WoQ1h6Vhq2eMeaXY02E26WQIU1jOEi0JeZ4tqOMQ== X-Received: by 2002:a05:620a:2051:: with SMTP id d17mr8211283qka.403.1610012704444; Thu, 07 Jan 2021 01:45:04 -0800 (PST) MIME-Version: 1.0 References: <1609332331-2456-1-git-send-email-vjitta@codeaurora.org> In-Reply-To: <1609332331-2456-1-git-send-email-vjitta@codeaurora.org> From: Alexander Potapenko Date: Thu, 7 Jan 2021 10:44:53 +0100 Message-ID: Subject: Re: [PATCH v4 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE To: Vijayanand Jitta Cc: Minchan Kim , dan.j.williams@intel.com, broonie@kernel.org, Masami Hiramatsu , LKML , Andrew Morton , ylal@codeaurora.org, vinmenon@codeaurora.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 30, 2020 at 1:46 PM wrote: > > From: Yogesh Lal > > Use STACK_HASH_ORDER_SHIFT to configure STACK_HASH_SIZE. I think "ORDER_SHIFT" is somewhat redundant, as "SMTH_ORDER" already means this is a power of two we'll be using for shifting. Leaving this up to you. Alex