Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: tegra: Add power-domain for Tegra210 HDA
To:     Sameer Pujar <spujar@nvidia.com>, <thierry.reding@gmail.com>,
        <robh+dt@kernel.org>
CC:     <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
References: <1609995970-12256-1-git-send-email-spujar@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <1dfc080c-f587-d19f-65c9-b3220b3202a0@nvidia.com>
Date:   Thu, 7 Jan 2021 09:48:04 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1609995970-12256-1-git-send-email-spujar@nvidia.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07/01/2021 05:06, Sameer Pujar wrote:
> HDA initialization is failing occasionally on Tegra210 and following
> print is observed in the boot log. Because of this probe() fails and
> no sound card is registered.
> 
>   [16.800802] tegra-hda 70030000.hda: no codecs found!
> 
> Codecs request a state change and enumeration by the controller. In
> failure cases this does not seem to happen as STATETS register reads 0.
> 
> The problem seems to be related to the HDA codec dependency on SOR
> power domain. If it is gated during HDA probe then the failure is
> observed. Building Tegra HDA driver into kernel image avoids this
> failure but does not completely address the dependency part. Fix this
> problem by adding 'power-domains' DT property for Tegra210 HDA. Note
> that Tegra186 and Tegra194 HDA do this already.
> 
> Fixes: 742af7e7a0a1 ("arm64: tegra: Add Tegra210 support")
> Depends-on: 96d1f078ff0 ("arm64: tegra: Add SOR power-domain for Tegra210")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra210.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> index 4fbf8c1..fd33b4d 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> @@ -997,6 +997,7 @@
>  			 <&tegra_car 128>, /* hda2hdmi */
>  			 <&tegra_car 111>; /* hda2codec_2x */
>  		reset-names = "hda", "hda2hdmi", "hda2codec_2x";
> +		power-domains = <&pd_sor>;
>  		status = "disabled";
>  	};

Thanks!

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic