Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 Jan 2021 13:12:40 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Jiri Olsa <jolsa@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexei Budankov <abudankov@huawei.com>
Subject: Re: [PATCHv4 0/4] perf tools: Allow to enable/disable events via
 control pipe
Message-ID: <20210107121240.GA1019522@krava>
References: <20201226232038.390883-1-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201226232038.390883-1-jolsa@kernel.org>
Precedence: bulk

On Sun, Dec 27, 2020 at 12:20:34AM +0100, Jiri Olsa wrote:
> hi,
> adding support to enable/disable specific events via control
> file via following commands:
> 
>     # echo 'enable sched:sched_process_fork' > control
>     # echo 'disabled sched:sched_process_fork' > control
> 
> v4 changes:
>   - some of the patches got merged
>   - rebased to latest perf/core
>   - fixed changelogs
>   - added 'ping' command

any reviews?

thanks,
jirka

> 
> v3 changes:
>   - use ' ' instead of '-' in syntax and add command argument
>     processing [Arnaldo]
>   - add options to evlist [Arnaldo]
>   - add man page changes
> 
> v2 changes:
>   - added acks
>   - change list to evlist [Arnaldo]
>   - add evlist-verbose command [Arnaldo]
>   - add '' to enale-/disable- error message
> 
> The code is available in here:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/control
> 
> thanks,
> jirka
> 
> 
> ---
> Jiri Olsa (4):
>       perf tools: Allow to enable/disable events via control file
>       perf tools: Add evlist control command
>       perf tools: Add stop control command
>       perf tools: Add ping control command
> 
>  tools/perf/Documentation/perf-record.txt |  15 ++++++++++++---
>  tools/perf/builtin-record.c              |  13 +++++++------
>  tools/perf/builtin-stat.c                |   5 +++--
>  tools/perf/util/evlist.c                 | 112 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  tools/perf/util/evlist.h                 |   6 ++++++
>  tools/perf/util/evsel_fprintf.c          |   2 ++
>  tools/perf/util/python-ext-sources       |   1 +
>  tools/perf/util/setup.py                 |   2 +-
>  8 files changed, 141 insertions(+), 15 deletions(-)
>