Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210106012301.71260-1-yebin10@huawei.com>
In-Reply-To: <20210106012301.71260-1-yebin10@huawei.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 7 Jan 2021 14:28:55 +0100
Message-ID: <CAJZ5v0jhXFOW3DsM2xsSq2fZmeGOz=ARTH3VkcTNZ7m9cyYVgA@mail.gmail.com>
Subject: =?UTF-8?Q?Re=3A_=5BPATCH=5D_ACPI=3A_PM=3A_s2idle=3A_Remove_useless_variabl?=
        =?UTF-8?Q?e_=E2=80=98obj=5Fnew=E2=80=99_in_lpi=5Fdevice=5Fget=5Fconstraints=5Famd?=
To:     Ye Bin <yebin10@huawei.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Jan 6, 2021 at 2:13 AM Ye Bin <yebin10@huawei.com> wrote:
>
> Fix warning:
> drivers/acpi/x86/s2idle.c:138:25: warning: variable ‘obj_new’ set but
> not used [-Wunused-but-set-variable]
>       union acpi_object *obj_new;
>                                ^~~~~~~
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
>  drivers/acpi/x86/s2idle.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> index 25fea34b544c..e5fb17fd1020 100644
> --- a/drivers/acpi/x86/s2idle.c
> +++ b/drivers/acpi/x86/s2idle.c
> @@ -135,12 +135,10 @@ static void lpi_device_get_constraints_amd(void)
>
>                                 for (k = 0; k < info_obj->package.count; ++k) {
>                                         union acpi_object *obj = &info_obj->package.elements[k];
> -                                       union acpi_object *obj_new;
>
>                                         list = &lpi_constraints_table[lpi_constraints_table_size];
>                                         list->min_dstate = -1;
>
> -                                       obj_new = &obj[k];
>                                         switch (k) {
>                                         case 0:
>                                                 dev_info.enabled = obj->integer.value;
> --

I posted an alternative fix for this issue on Tue, sorry:

https://patchwork.kernel.org/project/linux-pm/patch/3607102.xkEKTzvHZR@kreacher/