Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210101125629.20974-1-jiaxun.yang@flygoat.com>
 <35ac853a-266c-6944-6e5e-6286456865e3@redhat.com> <CAJZ5v0jcCD3qWUJQcS+nFVJWSCQEbq2eN3i07mN8yFr3WZD9dg@mail.gmail.com>
 <6a29f338-d9e4-150c-81dd-2ffb54f5bc35@redhat.com> <CAJZ5v0je41iXQnr3m-RY9fD_C-qnqbLdqYMvUzp0qgBwEvVoJA@mail.gmail.com>
 <9e745724-d704-6250-9bfb-e347f3611ec4@redhat.com>
In-Reply-To: <9e745724-d704-6250-9bfb-e347f3611ec4@redhat.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 7 Jan 2021 14:50:51 +0100
Message-ID: <CAJZ5v0gSCpZ6O+o7uXQKyQN+xOWhQSjiRqdqSdkez=ZsgCaOjg@mail.gmail.com>
Subject: Re: [PATCH 0/2] IdeaPad platform profile support
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Mark Gross <mgross@linux.intel.com>,
        Ike Panhc <ike.pan@canonical.com>,
        Mark Pearson <markpearson@lenovo.com>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 6, 2021 at 10:17 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 1/5/21 6:18 PM, Rafael J. Wysocki wrote:
> > On Mon, Jan 4, 2021 at 9:58 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> <snip>
>
> >> Patch 1/2 does use a slightly different approach then I suggest above,
> >> thinking more about this it would be cleaner IMHO to just pass the
> >> cur_profile pointer to the callbacks as the pseudo-code patch which I
> >> wrote above does. Drivers which use globals can then just ignore
> >> the extra argument (and keep the platform_profile_handler struct const)
> >> where as drivers which use dynamic allocation can embed the struct in
> >> their driver's data-struct.
> >
> > Agreed.
>
> Note that Jiaxun has provided a v2 of this patch-set with patch 1/2 implementing
> the new approach.
>
> Can you merge merge that patch please and then once you're happy that this
> has seen enough exposure in -next, provide me with an immutable branch with
> the 3 platform-profile patches in it ?

I will, thanks!