Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?utf-8?Q?Aur=C3=A9lien?= Aptel <aaptel@suse.com>
To:     Yejune Deng <yejune.deng@gmail.com>,
        Steve French <smfrench@gmail.com>
Cc:     Steve French <sfrench@samba.org>,
        CIFS <linux-cifs@vger.kernel.org>,
        samba-technical <samba-technical@lists.samba.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cifs: fix msleep() is imprecise
In-Reply-To: <CABWKuGUj41Qa-y_cApNNvLfTQPLJi2adr+ZKN6RpwFoemskoKg@mail.gmail.com>
References: <1607591258-13865-1-git-send-email-yejune.deng@gmail.com>
 <CAH2r5mvgjFWwEcqt8nfiU_1GJQUU7jN=eNT-t6SBEK8jke0Msg@mail.gmail.com>
 <CABWKuGUj41Qa-y_cApNNvLfTQPLJi2adr+ZKN6RpwFoemskoKg@mail.gmail.com>
Date:   Thu, 07 Jan 2021 15:03:17 +0100
Message-ID: <87r1mw3kuy.fsf@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost (2003:fa:705:9f19:3297:f46:6b4b:f1a6) by ZR0P278CA0027.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Thu, 7 Jan 2021 14:03:19 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0b1af3e8-2d0c-4e72-a857-08d8b314fcbe
X-MS-TrafficTypeDiagnostic: VI1PR04MB3230:
X-Microsoft-Antispam-PRVS: <VI1PR04MB3230DF26D20F3F4294F9FB5BA8AF0@VI1PR04MB3230.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: VJ/HNMofplh673jG9CXyAGO1yoqk+e5al0MO9K+Y6qmlDjIlv+Lj76I25XH/tCFYSvKbQ3aU8Km6WahDRFNRzaNgXqaFmOl2fIjcmeCg+u+GGR8vsf7NAC7UFWPtOwp+gl36rhPN6+ZfX6KJsSgfp4MigVpqvc1XDA6R039v6EAqRityN9kECkXq7Tr6vkyvjMt+J5G79PsmuMMsI0A4n51w7tKDjHj3S2ojPJGVfhdkpSl2CDtHrxcTvto20Bn6Y6loUE7N4W5EW7ufoD0u3xg+Q1bsIbLisHlWh9/C24el+USf4p53r6Ub1RYB2/f4wAp+fmTSoqP2Ue6wo7gS2YtUozI/5BOm5FEc1wOUrts2DK/3PAueJV8Zmxsp9DunO7Sfcf2iA+nz/zMaJbLvLA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3359.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(136003)(396003)(376002)(346002)(66574015)(66946007)(6496006)(52116002)(4744005)(66476007)(66556008)(36756003)(83380400001)(2616005)(478600001)(6486002)(316002)(4326008)(16526019)(54906003)(86362001)(110136005)(186003)(2906002)(8676002)(5660300002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bjU4MkdaUldDOTlPR2VBQ1JWMzVORm1pUHgxaDMwMWpCTHpENXBQdDRNVjNQ?=
 =?utf-8?B?Q3UxdncrUXhIRjlMa0lHR2lqNzg2aDhoUGNzdWYzbmQ3UDBhanZyZ2krTlV5?=
 =?utf-8?B?ck5QN3VCQitFVVYwNDdaQXB3NkJEcEhrZk1rMHF4aTQvVnJ0VWRpT21RWVkx?=
 =?utf-8?B?YVEybnlzMGo3TEdTM3dSTEdSSTV4STZGWjdCSWp1ZXFqN0pJTDFKdTVMdzVW?=
 =?utf-8?B?OHNqYUxTa2lwdnlWVHZRUmJsQW13UUJwdU0wNUZCZnRabjBjaVdKM1hsanVY?=
 =?utf-8?B?VkFRcU9tbFQ2S0dIbDhkYkQ3WUQ1SCtqVWtRVlduYTRENmhCeitmdXRDM0tN?=
 =?utf-8?B?NjFaRVZrWUp2VUQ1RGdjMXdYQjh2QTlvbnVVWjJacUxOT2xTeWk2Q1B4V3I5?=
 =?utf-8?B?K2ZiSDE4MTJpelI1NWpOZUU1ejh6ZWZMdlMwVzFaZm9CZ3V4S2hGdXF6d1kr?=
 =?utf-8?B?bFBxaWhvb3A2SHh3aXNVZ0JRV1FtczY3TldhSnI0WTNIbEhYSkpnYXcwNHBy?=
 =?utf-8?B?c2trMGlkd3BGcms1TWp3Y1NscUhlTWZlbnVBSnozY1duMEoxSFQ1SXd0STlK?=
 =?utf-8?B?eGNmeVRURnpnbUZET3VBSXJsVFdRVm1Zc1pJcFk3V1Z2VUxOdFVZM1ZSVXpn?=
 =?utf-8?B?S2pMM1k3TExkSjlmU1ZEVG5jeHRqeWxxdlh4Y3gvL3RPcTM4WEt4VVVEN3A1?=
 =?utf-8?B?UDB1SGZ6Ky8zTUdZK3pGSzlxc0duK0UzOW93bXYram10cjlIRXQvR1IycTJQ?=
 =?utf-8?B?T1BZZFNzc1R4YkQyVE1hekpFQUNvZTV5TnZXdVZBZUEzbmNMNGwxQWxaK3U2?=
 =?utf-8?B?d3JDdzVuU1NmUDl6TzNmSXNlQy94MkxjQllBTm5OTFZNeSsrNzNiMTdiRmtO?=
 =?utf-8?B?V3hVR2R3bFVIQjFNVHBVRnFPelBSRjBXdE9JanVTS0E1Y2pvbEtVZ1hzZ044?=
 =?utf-8?B?alJOc0hocEFUa3VabkYyQWJKTE1kK2ZabURCVWFFYlNPWHBJcVFDS25qOG8z?=
 =?utf-8?B?ckxvOHBUUnNjdEt1ck5XTHJRZ1l0cExSWmpRUEZPTkpPUmpvbUpLREs4a1Yy?=
 =?utf-8?B?cG5yeUw5UUZjc3NpTlYzS1FrcXBqQmNiMEwreWNDY0xLNzhqMTRZUXJjMG8w?=
 =?utf-8?B?NXVUWnRBdTVOUk8wTGJITXFCMUpacml5UnZEV0d5aXlDeFpMcU11a2h2cnps?=
 =?utf-8?B?MUgwbUFIRTVVU09aeVFEUVZxUW5FcTNkMEpTZWN1MW9OSjkzNWUvWVR5cnZ5?=
 =?utf-8?B?V1dsVWZGYThiS282UVUzc2djVzZvRUw1T1hIbVdsT3FNSml4N2JVVk1sMHNv?=
 =?utf-8?B?eWIxRWpIUmNWbzZyckxaOW5QeS9OTVZ4bXFFcHdSY1VQUkFxOGxSTllCTUFm?=
 =?utf-8?Q?KGol7hPM7YqrUdjrocXdeQ1Qgb0kEl14=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2021 14:03:19.3326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b1af3e8-2d0c-4e72-a857-08d8b314fcbe
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FgrAYSg4SPYUwUmdycvXWRlAvXQ0nAr5D0inDfkp14Z6sS3ogQcmtkoFhWWKWw0s
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3230
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yejune Deng <yejune.deng@gmail.com> writes:
> No=E3=80=82I just see Documentation/timers/timers-howto.rst and don't
> recommend using msleep() for (1ms - 20ms). It recommends using
> usleep_range(). And fsleep() is flexible sleeping.

I think what Steve is asking is does using fsleep() changes anything
regarding yielding i.e. does it affect how tasks/processes get
scheduled. AFAIK, this msleep(1) in the code is to give a hint and let
the kernel run other tasks, in particular the ones waiting on the
request and response queue.

Cheers,
--=20
Aur=C3=A9lien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, D=
E
GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 247165 (AG M=C3=BC=
nchen)