Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 Jan 2021 16:29:33 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Corey Minyard <cminyard@mvista.com>
Cc:     minyard@acm.org, Jiri Slaby <jirislaby@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Hurley <peter@hurleysoftware.com>,
        brian.bloniarz@gmail.com
Subject: Re: [PATCH 2/2] drivers:tty:pty: Fix a race causing data loss on
 close
Message-ID: <X/co3Uq719eXempQ@kroah.com>
References: <20201124004902.1398477-1-minyard@acm.org>
 <20201124004902.1398477-3-minyard@acm.org>
 <20210102144109.GA4173@minyard.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210102144109.GA4173@minyard.net>
Precedence: bulk

On Sat, Jan 02, 2021 at 08:41:09AM -0600, Corey Minyard wrote:
> On Mon, Nov 23, 2020 at 06:49:02PM -0600, minyard@acm.org wrote:
> > From: Corey Minyard <cminyard@mvista.com>
> > 
> > Remove the tty_vhangup() from the pty code and just release the
> > redirect.  The tty_vhangup() results in data loss and data out of order
> > issues.
> 
> It's been a while, so ping on this.  I'm pretty sure this is the right
> fix, the more I've thought about it.

Sorry, was waiting to see if someone else would review it :)

Will go do so now...

greg k-h