Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp432107pxu; Thu, 7 Jan 2021 08:32:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxVIafE0V3C5cR6og74R4ISDPg31axOsQ8dNn2rLx7VZxDHsgt2N5kWCSCxDVoLq1bfja8N X-Received: by 2002:a17:906:ae41:: with SMTP id lf1mr7036979ejb.369.1610037124251; Thu, 07 Jan 2021 08:32:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610037124; cv=none; d=google.com; s=arc-20160816; b=LpTeEoDHkzUvxp6YqdXmOYKOYYd8erxgTrYFnVP9qlNr/8FBD75it0cyDU1D9dhj4G lKDlM2UvIMSHcomI7vxO7XjQGi5oVjc+S7077X/5CU3g/UNujLgzBuhOfLJokEsBLmvP oqK8UVUWLdmr8C8ZuhZV7gn8xtbyBq1q9dMqBbmm1e3abyh6kIwzIugGsWb/d2TTGz/B 0ky9P8WB6OOK2Idc3yHF7meO27JSAA6yl7xFLsDFWrQu9UMkZOdhoFYcD6Tabd6bgZGF tr0NbdiRX/xAwGOglkRHaVUnfu91U7P3ZjeqD7zIUBPoO/53zNA6X798v6IvZpSSDpt9 yYYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=GTtKKl8QtVl053gTimygdSCyQ6GmC+rs+XcLG1wNpwk=; b=cTIpNvjBFt7nIQO+wm7Sa+QJLWFzO1pq29LC61QHSPi1SidRLBSDda9rf2D7rPyxKn +k5C59qINotsZeIRMq4ELHbXWSYspFFRAGlA1WoUoKXN4Vc6jJBQvn0yw0E85OlJvArG pwbAkbGAjaT8piY+tgrjCZo4kw+Ms3NlRhqbWbf8oI6C4wBCWyrD0bApFYWrfWEuS96G c0vwY5X2I+NQPtJ5CMB4pBd09ziGFpwdmg2nyTkXGtYzcW3nvzOqRAZH0lbsCp3g/wWL Dg+dTgzjwHIG2LMH9JHsOuvqDn81SWihtV6/9uT3Wyq6n6XBpDtUUWuXXJl8Z0L4JMsO 8uAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sb9si2538042ejb.655.2021.01.07.08.31.40; Thu, 07 Jan 2021 08:32:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728879AbhAGQaC (ORCPT + 99 others); Thu, 7 Jan 2021 11:30:02 -0500 Received: from elvis.franken.de ([193.175.24.41]:34742 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726468AbhAGQ3q (ORCPT ); Thu, 7 Jan 2021 11:29:46 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kxY9o-0000Mi-05; Thu, 07 Jan 2021 17:29:04 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 825D2C080E; Thu, 7 Jan 2021 17:28:03 +0100 (CET) Date: Thu, 7 Jan 2021 17:28:03 +0100 From: Thomas Bogendoerfer To: Jinyang He Cc: Jiaxun Yang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: zboot: Avoid endless loop in clear BSS. Message-ID: <20210107162803.GF11882@alpha.franken.de> References: <1609894059-6112-1-git-send-email-hejinyang@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1609894059-6112-1-git-send-email-hejinyang@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2021 at 08:47:39AM +0800, Jinyang He wrote: > Commit 2ee1503e546f ("MIPS: zboot: head.S clean up"). > > After .noreorder removed, clear BSS fall into endless loop. The bne > instruction will add nop to the delay slot at compile time. So a0 > register will not increment by 4. Fix it and clear BSS from _edata > to (_end - 1). > > Signed-off-by: Jinyang He > --- > arch/mips/boot/compressed/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]