Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <3770e4f3025e48759ad64513a457f1276031d900.camel@linux.ibm.com>
Subject: Re: scsi: Add diagnostic log for scsi device reset
From:   James Bottomley <jejb@linux.ibm.com>
Reply-To: jejb@linux.ibm.com
To:     lijinlin <lijinlin3@huawei.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, martin.petersen@oracle.com
Cc:     linfeilong@huawei.com, liuzhiqiang26@huawei.com
Date:   Thu, 07 Jan 2021 08:49:07 -0800
In-Reply-To: <c391120e-897a-0ee1-d01a-0defe504d6df@huawei.com>
References: <c391120e-897a-0ee1-d01a-0defe504d6df@huawei.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-01-07 at 19:43 +0800, lijinlin wrote:
[...]
> -		SCSI_LOG_ERROR_RECOVERY(3,
> +		if (bdr_scmd->request && bdr_scmd->request->rq_disk)
>  			sdev_printk(KERN_INFO, sdev,
> -				     "%s: Sending BDR\n", current-
> >comm));
> +				     "[%s] Sending device reset\n",
> +				     bdr_scmd->request->rq_disk-
> >disk_name);

Not everything is a SCSI disk.  If we apply this patch, we lose traces
for any non-disk device that get reset ... for tapes this can be really
important to know.

James