Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210107123916.189748-1-colin.king@canonical.com>
In-Reply-To: <20210107123916.189748-1-colin.king@canonical.com>
From:   Sunil Kovvuri <sunil.kovvuri@gmail.com>
Date:   Thu, 7 Jan 2021 22:31:30 +0530
Message-ID: <CA+sq2CcPRuQijfOFA74KrNF9E5tj-QqH_0nNC21fT=rqkuuCcw@mail.gmail.com>
Subject: Re: [PATCH] octeontx2-af: fix memory leak of lmac and lmac->name
To:     Colin King <colin.king@canonical.com>
Cc:     Sunil Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geetha sowjanya <gakula@marvell.com>,
        Jerin Jacob <jerinj@marvell.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Nithya Mani <nmani@marvell.com>,
        Linux Netdev List <netdev@vger.kernel.org>,
        kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 7, 2021 at 6:11 PM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the error return paths don't kfree lmac and lmac->name
> leading to some memory leaks.  Fix this by adding two error return
> paths that kfree these objects
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 1463f382f58d ("octeontx2-af: Add support for CGX link management")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Thanks for the fix, looks good to me.

Sunil.