Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: n59yNbGiWLtgfpxTZh7h8Ywl0d9XduvmDrUkpJGKrj8Scx51SVwc63F6pet9DP1FfO+jEFuv42
 mvKI3VdZXyFg==
IronPort-SDR: oQqX8k3CPRWNgw8Z6NW7bkTAm+ui5+EdW7HL4igdck6cGlbtNMdcHQYlIGYjvHXkBdLMP3/Hmt
 urv4J0HWsWlA==
From:   "Bae, Chang Seok" <chang.seok.bae@intel.com>
To:     "Liu, Jing2" <jing2.liu@intel.com>
CC:     "bp@suse.de" <bp@suse.de>, "luto@kernel.org" <luto@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@kernel.org" <mingo@kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "Brown, Len" <len.brown@intel.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 10/21] x86/fpu/xstate: Update xstate save function to
 support dynamic xstate
Thread-Topic: [PATCH v3 10/21] x86/fpu/xstate: Update xstate save function to
 support dynamic xstate
Thread-Index: AQHW2UTrfabGiuGaq0+dx4jPc8ZDRKob7zCAgACnYAA=
Date:   Thu, 7 Jan 2021 18:40:21 +0000
Message-ID: <29CB32F5-1E73-46D4-BF92-18AD05F53E8E@intel.com>
References: <20201223155717.19556-1-chang.seok.bae@intel.com>
 <20201223155717.19556-11-chang.seok.bae@intel.com>
 <BYAPR11MB3256BBBB24F9131D99CF7EF5A9AF0@BYAPR11MB3256.namprd11.prod.outlook.com>
In-Reply-To: <BYAPR11MB3256BBBB24F9131D99CF7EF5A9AF0@BYAPR11MB3256.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15331A1012BFA14AA45075BB840735D2@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cb335b7-d15b-43e6-baaa-08d8b33bb099
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2021 18:40:21.8559
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /arqb4WkgxGKaPKHo0zvuYKt5RLLt/ZBZ/gVkZnpiBVoKc5dIZ/Ml/8yaM0WOdy6EEEDqwd00a06rit/APezk/oFONng5ecW1zXlkO4rVPE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4837
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 7, 2021, at 17:41, Liu, Jing2 <jing2.liu@intel.com> wrote:
>=20
> static void kvm_save_current_fpu(struct fpu *fpu)  {
> +	struct fpu *src_fpu =3D &current->thread.fpu;
> +
> 	/*
> 	 * If the target FPU state is not resident in the CPU registers, just
> 	 * memcpy() from current, else save CPU state directly to the target.
> 	 */
> -	if (test_thread_flag(TIF_NEED_FPU_LOAD))
> -		memcpy(&fpu->state, &current->thread.fpu.state,
> +	if (test_thread_flag(TIF_NEED_FPU_LOAD)) {
> +		memcpy(&fpu->state, &src_fpu->state,
> 		       fpu_kernel_xstate_min_size);
> For kvm, if we assume that it does not support dynamic features until thi=
s series,
> memcpy for only fpu->state is correct.=20
> I think this kind of assumption is reasonable and we only make original x=
state work.
>=20
> -	else
> +	} else {
> +		if (fpu->state_mask !=3D src_fpu->state_mask)
> +			fpu->state_mask =3D src_fpu->state_mask;
>=20
> Though dynamic feature is not supported in kvm now, this function still n=
eed
> consider more things for fpu->state_mask.

Can you elaborate this? Which path might be affected by fpu->state_mask
without dynamic state supported in KVM?

> I suggest that we can set it before if...else (for both cases) and not ch=
ange other.=20

I tried a minimum change here.  The fpu->state_mask value does not impact t=
he
memcpy(). So, why do we need to change it for both?

Thanks,
Chang=