Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] usb: dwc3: Replace of_reset_control_array_get()
To:     Yejune Deng <yejune.deng@gmail.com>, balbi@kernel.org,
        gregkh@linuxfoundation.org, p.zabel@pengutronix.de
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1604395500-8086-1-git-send-email-yejune.deng@gmail.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <49ee0444-4e0f-1dbe-c59a-74c72b34b140@gmail.com>
Date:   Thu, 7 Jan 2021 22:33:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.2
MIME-Version: 1.0
In-Reply-To: <1604395500-8086-1-git-send-email-yejune.deng@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

03.11.2020 12:25, Yejune Deng пишет:
> of_reset_control_array_get_optional_exclusive() looks more readable
> 
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> ---
>  drivers/usb/dwc3/dwc3-of-simple.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index e62ecd2..e358ff0 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -52,8 +52,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
>  	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
>  		simple->need_reset = true;
>  
> -	simple->resets = of_reset_control_array_get(np, false, true,
> -						    true);
> +	simple->resets = of_reset_control_array_get_optional_exclusive(np);
>  	if (IS_ERR(simple->resets)) {
>  		ret = PTR_ERR(simple->resets);
>  		dev_err(dev, "failed to get device resets, err=%d\n", ret);
> 

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>