Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp568347pxu; Thu, 7 Jan 2021 12:06:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWronrYjbyksomRsg5+ygL6Jrcs7ptDHLKVvDMTuRmxbMEShnNeeU6fBPpsAvxfYytF9Tw X-Received: by 2002:a50:d2d2:: with SMTP id q18mr2816461edg.346.1610049986238; Thu, 07 Jan 2021 12:06:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610049986; cv=none; d=google.com; s=arc-20160816; b=EecyOgfInzLBrrj3RikLAfec/fXylKxPiswWOrCXx23zrUReetwJzW2UFmovup+D4T wd4AE2EpgUQ2NHd6Pl6H3gsZC8BSJCtvviViyL8BL6o57n0+P3HQso4nwCmuTGA/rZm6 19rlQuOVYOeZG+NsJ+OzImn4TZd//N2RXAsVKtkfdhN0cQCfXpDknFo7UAoVzOTXoFt+ PmeGmJfOkhA1Ul7wmSAKi7BFnnrc5bJ2D4Z6ddD5Fr6dlM1epapiPgBdY6zcP3Lej+2f GjCF9Edr1/WsLFe34nvpvVhOIlFwXZ1PYhDig/1j8Kx9hahMC9YpldJGk4eVGWElZCwr V5lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=81Cs5ZVvcUGrn+4VCJyjf33GzfHtsGNpmOiHWIE9stU=; b=t4IixvTJTCLoSIAWHK0OvsFwow8pkFNMckN1tgBxHZOmzFsG5JnoTbY/Z9tv5wtJuu 5Ohazi18I6I30ybk5lnixeYPMkPb6b54ZDQlokY7heCoeXPGpywO0zxEw2sWRVhe/pIT 3cUpzxUcvedXZ8AU9v3JUv+WSpfr0xlBvrxuGCTUWC4mFi75qNjJEJhNXhmeoHb+8MGL LZ1ycETjY2cDSSd3MADVSpzijvuQt/eSqns2QH5P19uMdthI/I4/4EsVaLa1fdPdP1ZV Qfms77ORB1Xm5wrle/f976YJKAGSosZW2olOH/oEH3OpRToeqAZEx4AjuBgHWqBU67LR TmeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tsQhkf7O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d9si2688426eds.129.2021.01.07.12.06.02; Thu, 07 Jan 2021 12:06:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tsQhkf7O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726784AbhAGUE7 (ORCPT + 99 others); Thu, 7 Jan 2021 15:04:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:51094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbhAGUE7 (ORCPT ); Thu, 7 Jan 2021 15:04:59 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 911B6233F6; Thu, 7 Jan 2021 20:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610049859; bh=k6MeESPQHWsaUNptevG0GHmDrUuFq1OLKqaK3nKkK1Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tsQhkf7O7aIZveSUDVWOWn9yNcOdvQ7H2H6ltc0N7bBZBe5oHaFQlkg1LwkSFgWZc jai74Fsb6x22q5tvTK9EdQQmXy8Oa2KrfAP+PHeWzQeEs3W3u5sbIH2M5noEJ2fu02 hMrzE4nNdTiOmNhNjZPpl9uEAUGJ4weYa5deC8HE= Date: Thu, 7 Jan 2021 21:05:38 +0100 From: Greg Kroah-Hartman To: Saravana Kannan Cc: "Rafael J. Wysocki" , kernel-team@android.com, linux-kernel@vger.kernel.org, Jisheng Zhang , Kevin Hilman , John Stultz , Nicolas Saenz Julienne , Marc Zyngier Subject: Re: [PATCH v1 0/5] Enable fw_devlink=on by default Message-ID: References: <20201218031703.3053753-1-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201218031703.3053753-1-saravanak@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 17, 2020 at 07:16:58PM -0800, Saravana Kannan wrote: > As discussed in LPC 2020, cyclic dependencies in firmware that couldn't > be broken using logic was one of the last remaining reasons > fw_devlink=on couldn't be set by default. > > This series changes fw_devlink so that when a cyclic dependency is found > in firmware, the links between those devices fallback to permissive mode > behavior. This way, the rest of the system still benefits from > fw_devlink, but the ambiguous cases fallback to permissive mode. > > Setting fw_devlink=on by default brings a bunch of benefits (currently, > only for systems with device tree firmware): > * Significantly cuts down deferred probes. > * Device probe is effectively attempted in graph order. > * Makes it much easier to load drivers as modules without having to > worry about functional dependencies between modules (depmod is still > needed for symbol dependencies). > > Greg/Rafael, > > Can we get this pulled into 5.11-rc1 or -rc2 soon please? I expect to > see some issues due to device drivers that aren't following best > practices (they don't expose the device to driver core). Want to > identify those early on and try to have them fixed before 5.11 release. > See [1] for an example of such a case. Now queued up in my tree, will show up in linux-next in a few days, let's see what breaks! :) And it is scheduled for 5.12-rc1, not 5.11, sorry. thanks, greg k-h