Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932170AbWIINYZ (ORCPT ); Sat, 9 Sep 2006 09:24:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932171AbWIINYZ (ORCPT ); Sat, 9 Sep 2006 09:24:25 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:42979 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932170AbWIINYY (ORCPT ); Sat, 9 Sep 2006 09:24:24 -0400 Message-ID: <4502C086.2080302@garzik.org> Date: Sat, 09 Sep 2006 09:24:22 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.5 (X11/20060808) MIME-Version: 1.0 To: Grzegorz Kulewski CC: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@osdl.org Subject: Re: [PATCH] linux/magic.h for magic numbers References: <20060909110245.GA9617@havoc.gtf.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.3 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 30 Grzegorz Kulewski wrote: > On Sat, 9 Sep 2006, Jeff Garzik wrote: >> An IRC discussion sparked a memory: most filesystems really don't >> need to put anything at all in include/linux. Excluding API-ish >> filesystems like procfs, just about the only filesystem symbols that >> get exported outside of __KERNEL__ are the *_SUPER_MAGIC symbols, >> and similar symbols. >> >> After seeing the useful attributes of linux/poison.h, I propose a >> similar linux/magic.h. > > But... if some patch changes this file (like adding new magic symbol) it > will cause large part of the kernel to rebuild without any good reason. No? No :) * The days when linux/fs.h included individual filesystem headers is long gone. Only the filesystems themselves typically include the linux/foo_fs*.h files these days. * It's not like we add new filesystems to the kernel very often. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/