Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp626558pxu; Thu, 7 Jan 2021 13:53:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJx0BMk5AhbQ4LAV2C1vq3zldO/ea0t72JY7r8GUKSjbCqfH2etoBWOJMCpEl5sNxj+VPBKG X-Received: by 2002:a50:a6de:: with SMTP id f30mr3236281edc.30.1610056412984; Thu, 07 Jan 2021 13:53:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610056412; cv=none; d=google.com; s=arc-20160816; b=GvGPzcYAYR+jOGXpQ6flIK1V4SzrkLSfzJUteQe0ilrqzgkxUgGmMiNDg27QY0dQMj fxJItOPeP5YFLIrjKBRCy+7eASe/XBRfpfo7U8y/sHqkqtnrEepNu938Uq0Ld2OxjSeZ OEpSQ8uxau4jmQ89SmblsYzcl0Ss304fXuwab7DxKysP0LUOAYIsAejeyR+/vsJXTwWO zu0yqSCGKajHEWgZSpVkZ/Y/++Aas3Kog6A3pOyfiClH2cfbFFcNye4y6aed8ahIalZA hLhqtFoH/trywg4iiVwRmyi11F2H4WgUGOoJ4ZReuBv5Vtc6NKRNEGQAj+3l0OEmIGuR opwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gkilXEcZuToD5vPEj+Iw2iyngHBEJ9jViAa6mux7/AE=; b=Ovhq+JeMlI7GBzrN1AtXJzFXkD4uEQ4BSE5e/jT+BQ/hYzav3Fw6jsxMZReF/oR1qI eb8DFGHPSrNX2+QoBeO+dAXYeHLE1govAMz1z5S3HBVGz7RgHjYBOxWz7ydutTd5i4n7 TXp4TeAYdIrlXjBXrWYDojQY8jOLR505ceAFLJeFUnAD+k76zMjBYvQwzrvRgDOS0pCv GA/vqZPRTPHsqYYwvo6csKBOf83XTvRNPp5sv9TzpR/P8ipTR0vRlpfJGphZ4jCu2/nL 6KFxdrO1HF54HnROH+aVdr4KKIYCZDerLLEDaO5h2rd07GmG6L1KbbvWUY0gvTinCGhV pnWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PnZqIrWh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n20si2856301edq.311.2021.01.07.13.53.09; Thu, 07 Jan 2021 13:53:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PnZqIrWh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727880AbhAGVw0 (ORCPT + 99 others); Thu, 7 Jan 2021 16:52:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbhAGVw0 (ORCPT ); Thu, 7 Jan 2021 16:52:26 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A02B0C0612FD for ; Thu, 7 Jan 2021 13:51:41 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id p18so6145673pgm.11 for ; Thu, 07 Jan 2021 13:51:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gkilXEcZuToD5vPEj+Iw2iyngHBEJ9jViAa6mux7/AE=; b=PnZqIrWhxcDfjmbGE75JBePgC4PFM1qGfPEhfhbT1bTzuSG6DEasZacDbvCKVBdceT T7zD6Zk+UVtji3j4dz5CGa/MDJC13QJ8zpkOon95bTSuKXsjnS9GueP4eo2zO3kxj2Ym uryPmXHf06rD6C34hfBrb7YcB9PLp2yQ/pERM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gkilXEcZuToD5vPEj+Iw2iyngHBEJ9jViAa6mux7/AE=; b=CQYM3ssbszOEug1Kmat1VfAot4afQpUNpt9MgvVBsrBrhWRsuebr+px4iY+KNLI6WZ 6N6goYhlIgc9q8gKaBRiD5YhxNLR32QWx4YCK/1GJXXr6uOIBSQie2K6L/MM1EzeR4Hv z8CYJGxcNwZRuV5y88+LEZ0UmMpQlMxJtRYWm3bc3+fvl90mHn8iIArsDSoPawDlStPO 3sGq966B6totn8PNIB3pOIAYAh8zGnbI6/AyR0ClRR8bOwG5RxBcrl6rzzIgsWS5/MGA G6qWgXes8+oxJjQvEzQqWOFs4n/bJWq6CMsOyxzkmR5MfpBill3298UrW5s/yQklJnrD 4TvQ== X-Gm-Message-State: AOAM531lw4uvW9U6NEG8egL9ojle+7Ul22br807RLP3/RNGjbmnHELPG wkcUE93XJppFlQ0JXnQhU1wY5w== X-Received: by 2002:a63:eb0c:: with SMTP id t12mr3820364pgh.7.1610056301288; Thu, 07 Jan 2021 13:51:41 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b6sm6608979pfd.43.2021.01.07.13.51.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 13:51:40 -0800 (PST) Date: Thu, 7 Jan 2021 13:51:39 -0800 From: Kees Cook To: Alexander Lobakin Cc: Thomas Bogendoerfer , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Fangrui Song , Huacai Chen , Pei Huang , Jiaxun Yang , Sami Tolvanen , Ingo Molnar , Ralf Baechle , Corey Minyard , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, stable@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH v4 mips-next 0/7] MIPS: vmlinux.lds.S sections fixes & cleanup Message-ID: <202101071351.1CFD6D8@keescook> References: <20210107123331.354075-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210107123331.354075-1-alobakin@pm.me> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2021 at 12:33:38PM +0000, Alexander Lobakin wrote: > This series hunts the problems discovered after manual enabling of > ARCH_WANT_LD_ORPHAN_WARN. Notably: > - adds the missing PAGE_ALIGNED_DATA() section affecting VDSO > placement (marked for stable); > - properly stops .eh_frame section generation. > > Compile and runtime tested on MIPS32R2 CPS board with no issues > using two different toolkits: > - Binutils 2.35.1, GCC 10.2.0; > - LLVM stack 11.0.0. Nice! Thanks for hunting down the corner cases. :) -- Kees Cook