Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ikjdqDm8rjbu6QhR97Pji9nilJ7kbJAWjWpRymVSW3hHkfjpU5JLXmJrg6ghZXAA8+Mh84MsWg
 23H1VYJaGrWw==
IronPort-SDR: 4saJ7QS+n8ISD5MG7mZzaCK3vDu/QggCM2ebRoIZcvCxoqYPnILhVQb0sOSCH4dxecYLbbUou8
 8cIkqhEu02Fw==
Subject: Re: [PATCH] x86/resctrl: add printf attribute to log function
To:     trix@redhat.com, fenghua.yu@intel.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, hpa@zytor.com
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org
References: <20201221160009.3752017-1-trix@redhat.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <25b32e4b-72c6-bf66-5088-7851b237329f@intel.com>
Date:   Thu, 7 Jan 2021 13:51:59 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <20201221160009.3752017-1-trix@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Tom,

On 12/21/2020 8:00 AM, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Attributing the function allows the compiler to more thoroughly
> check the use of the function with -Wformat and similar flags.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   arch/x86/kernel/cpu/resctrl/internal.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..c4d320d02fd5 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {
>   
>   void rdt_last_cmd_clear(void);
>   void rdt_last_cmd_puts(const char *s);
> +__printf(1, 2)
>   void rdt_last_cmd_printf(const char *fmt, ...);
>   
>   void rdt_ctrl_update(void *arg);
> 

This is a valuable addition, thank you.

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette