Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: UfuOZDwrtAm8+/FTa+YphTnwqo+wQz9/kqYxdAMlCyMyr44o4cS88LwxeuGTk4SEIFUAbj93PV
 CpF5BpY4J6QA==
IronPort-SDR: GzC942YKdS29oUlMaYhhxheHOEXQ50ohrsnXrMzcAUig5MAMgCsJiGcXO3bGdcBXVnhOsvxdi8
 5u6Vv0DHV53Q==
Subject: Re: [PATCH] x86/kernel/cpu/resctrl: replace 'of->kn->priv' with
 of_rft()
To:     zhouchuangao <chuangaozhou@gmail.com>, fenghua.yu@intel.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org
Cc:     hpa@zytor.com, linux-kernel@vger.kernel.org,
        zhouchuangao <zhouchuangao@xiaomi.com>
References: <1609758533-14337-1-git-send-email-zhouchuangao@xiaomi.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <614d7092-6234-a8e1-456a-752dcbf23f4f@intel.com>
Date:   Thu, 7 Jan 2021 14:29:14 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <1609758533-14337-1-git-send-email-zhouchuangao@xiaomi.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 1/4/2021 3:08 AM, zhouchuangao wrote:
> The use of 'of->kn->priv' to get rftype can be found in several
> places in arch/x86/kernel/cpu/resctrl/rdtgroup.c, which may reduce
> readability.
> 
> So replace the direct use 'of->kn->priv' with inline function
> of_rft(), which is more readable.

Readability can be subjective. The current assignment appears succinct 
and in my opinion the additional layer of indirection does not improve 
the readability.

Reinette