Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210106232641.459081-1-saravanak@google.com> <X/bNxMPWKq2nbqS4@kroah.com>
 <CAGETcx9NzCBGO4=Xo4h_BbbmxGr+VBoMvqFHkYKiQyCYNtBYGQ@mail.gmail.com>
In-Reply-To: <CAGETcx9NzCBGO4=Xo4h_BbbmxGr+VBoMvqFHkYKiQyCYNtBYGQ@mail.gmail.com>
From:   Saravana Kannan <saravanak@google.com>
Date:   Thu, 7 Jan 2021 15:19:38 -0800
Message-ID: <CAGETcx87ck19S0UQwdzLPBxGFns6hJbUX4HbfcOkA_MJy=t-8Q@mail.gmail.com>
Subject: Re: [PATCH v1] driver core: Fix device link device name collision
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Michael Walle <michael@walle.cc>,
        Android Kernel Team <kernel-team@android.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 7, 2021 at 3:17 PM Saravana Kannan <saravanak@google.com> wrote:
>
> On Thu, Jan 7, 2021 at 12:59 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Jan 06, 2021 at 03:26:41PM -0800, Saravana Kannan wrote:
> > > The device link device's name was of the form:
> > > <supplier-dev-name>--<consumer-dev-name>
> > >
> > > This can cause name collision as reported here [1] as device names are
> > > not globally unique. Since device names have to be unique within the
> > > bus/class, add the bus/class name as a prefix to the device names used to
> > > construct the device link device name.
> > >
> > > So the devuce link device's name will be of the form:
> > > <supplier-bus-name>:<supplier-dev-name>--<consumer-bus-name><consumer-dev-name>
> >
> > Minor nit, you forgot a ':' in the consumer side of the link here.  The
> > code is correct.
>
> Greg,
>
> Do you want me to send a v2 to fix this and add "fixes"? Or will you
> just fix it up when picking it up?
>

Actually, let me send a v2. There's another collision in the symlink's name.

-Saravana