Date: Sat, 9 Sep 2006 17:18:13 +0200
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: add support for w83697hg chip
References: <87fyf5jnkj.fsf@willow.rfc1149.net> <1157815525.6877.43.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1157815525.6877.43.camel@localhost.localdomain>
User-Agent: Mutt/1.5.11
From: Samuel Tardieu <sam@rfc1149.net>
Organization: RFC 1149 (see http://www.rfc1149.net/)
Content-Transfer-Encoding: 8bit
Message-Id: <2006-09-09-17-18-13+trackit+sam@rfc1149.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 979
Lines: 33

On  9/09, Alan Cox wrote:

| No kernel level locking anywhere in the driver. Yet you could have two
| people accessing it at once.

The device can be open only by one client at a time, this is checked in
open(), as was done in most other watchdog drivers.

| > +wdt_ioctl(struct inode *inode, struct file *file, unsigned int cmd,
| > +	  unsigned long arg)
| > +{
| > +	default:
| > +		return -ENOIOCTLCMD;
| 
| Should be -ENOTTY

We have 44 instances of ENOIOCTLCMD in other watchdog drivers
and zero instances of ENOTTY. Should we change all the instances, adopt
what has been done or just change the new ones?

| > +	printk(KERN_INFO PFX "Looking for W83697HG at address 0x%x\n", wdt_io);
| 
| KERN_DEBUG

Fixed in my copy.

  Sam

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/