Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210107090604.299270-1-albertccwang@google.com>
 <X/bZbluYJ0syB/Do@kroah.com> <20210108021642.GA4672@b29397-desktop>
In-Reply-To: <20210108021642.GA4672@b29397-desktop>
From:   Albert Wang <albertccwang@google.com>
Date:   Fri, 8 Jan 2021 11:43:11 +0800
Message-ID: <CANqn-rjVZRW+Y+_CMPJKBTi83VwSHV+Ow2k0AgooHRaKJozY6w@mail.gmail.com>
Subject: Re: [PATCH] Revert "usb: gadget: Quieten gadget config message"
To:     Peter Chen <hzpeterchen@gmail.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>, balbi@kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> Usually, the developer him(her)self wants to read it to know if current
> USB gadget enumerated and what speed is recognized, reading from the
> console by eyes is the quickest way. Without this message, there is no
> any messages when the USB gadget connects to host.
Yes, especially when enumeration USB3 failed then downgrade to USB2.

> If enable debug message, there are too many messages,
This is the reason why it is not a good solution, when I just need to
confirm what the enumeration result is.

--
Thanks,
Albert

On Fri, Jan 8, 2021 at 10:16 AM Peter Chen <hzpeterchen@gmail.com> wrote:
>
> On 21-01-07 10:50:38, Greg KH wrote:
> > On Thu, Jan 07, 2021 at 09:06:04AM +0000, Albert Wang wrote:
> > > This reverts commit 1cbfb8c4f62d667f6b8b3948949737edb92992cc.
> > >
> > > The log of USB enumeration result is a useful log and only occupies
> > > one line especially when USB3 enumeration failed and then downgrade
> > > to USB2.
> > >
> > > Signed-off-by: Albert Wang <albertccwang@google.com>
> > > ---
> > >  drivers/usb/gadget/composite.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> > > index c6d455f2bb92..5b0d6103a63d 100644
> > > --- a/drivers/usb/gadget/composite.c
> > > +++ b/drivers/usb/gadget/composite.c
> > > @@ -840,9 +840,9 @@ static int set_config(struct usb_composite_dev *cdev,
> > >             result = 0;
> > >     }
> > >
> > > -   DBG(cdev, "%s config #%d: %s\n",
> > > -       usb_speed_string(gadget->speed),
> > > -       number, c ? c->label : "unconfigured");
> > > +   INFO(cdev, "%s config #%d: %s\n",
> > > +        usb_speed_string(gadget->speed),
> > > +        number, c ? c->label : "unconfigured");
> >
> > When everything is working properly, the kernel should be quiet.  If you
> > have to see this message, you can turn it on at runtime, as Felipe
> > pointed out, to enable it for your system.  But it's not a good default
> > thing to have.
>
> For most production kernel (or kernel ready for customers), it may not enable
> CONFIG_DYNAMIC_DEBUG.
>
> >
> > What do you need to see this message for?  What tool relies on it?  Who
> > reads it?
> >
>
> Usually, the developer him(her)self wants to read it to know if current
> USB gadget enumerated and what speed is recognized, reading from the
> console by eyes is the quickest way. Without this message, there is no
> any messages when the USB gadget connects to host.
>
> If enable debug message, there are too many messages, but I think most
> developers may only need one information message to know if enumeration
> is established correctly.
>
> --
>
> Thanks,
> Peter Chen
>