Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Bean Huo <huobean@gmail.com>
Cc:     alim.akhtar@samsung.com, avri.altman@wdc.com,
        asutoshd@codeaurora.org, jejb@linux.ibm.com,
        martin.petersen@oracle.com, stanley.chu@mediatek.com,
        beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
        cang@codeaurora.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] scsi: ufs: Replace sprintf and snprintf with sysfs_emit
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq14kjsccw6.fsf@ca-mkp.ca.oracle.com>
References: <20210106211541.23039-1-huobean@gmail.com>
Date:   Thu, 07 Jan 2021 22:43:04 -0500
In-Reply-To: <20210106211541.23039-1-huobean@gmail.com> (Bean Huo's message of
        "Wed, 6 Jan 2021 22:15:41 +0100")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by DS7PR03CA0221.namprd03.prod.outlook.com (2603:10b6:5:3ba::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Fri, 8 Jan 2021 03:43:07 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 51c3bbb3-a6dd-4459-67a6-08d8b38783ae
X-MS-TrafficTypeDiagnostic: PH0PR10MB4437:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB4437D3A5ACC796D13B101A328EAE0@PH0PR10MB4437.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3UVXN4EAbNbRg+EpVRyhlwb1VfiBf8d2n94wzGz2bw2i7J24EC57mZzCj4yfvQ+UwreBK7YEBOAymnBD+76OI9aSd2913OQZDm/6G3jF65MVXIrrUMQLsxRW9bkM/ZlZrlpDivBXmJ4mUFFrGshUdIv3BTiLW6ULrlaRno56peUAwQJIXIUxeXLj0yNtApKpbn/gh2vjs88EFNxuddK9W5LEyvcuc94L7TneOmGg/Byi9m5/DJXT5H+ahaLB/svPTBiKhyHPLBFAdbuBr0yV2Kx6UJ3jKCwEpdM8EGfoVGPTaiSb/2NmWYrPAnBwYOR1JXTSSPRlcPS7Ewfa6U67jv6EIielVdKOxmK+MBAd62+BCqD+B26qnpjY6X56gJYejGHKHht1yuSPjw9jrAmQ5w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(366004)(39850400004)(396003)(346002)(4326008)(5660300002)(8936002)(66556008)(8676002)(558084003)(66476007)(6916009)(66946007)(7416002)(6666004)(36916002)(86362001)(16526019)(478600001)(186003)(316002)(2906002)(956004)(52116002)(7696005)(26005)(55016002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?T03eFK46+R0YE8bmdud/OJ/JDAiRKCtmrkE8wg+8+E5iewevBfjKXHV1Emwe?=
 =?us-ascii?Q?CQiO1P8jcBxW1iID++zF3vDcgwjwj/0oXuLbJV/bhr3ZXLieNnTdt0ntlV0/?=
 =?us-ascii?Q?/fQrFSqW1b4HVqUe4/MtGMyIZ4m3jz9OviARaG5FA00Zj/84GKYuF+7EtUzl?=
 =?us-ascii?Q?WFa4R67G/+BkJKT+FMaHC9YIKQhqO+TN8tP6gS7qX1WY6G8CehZFZtSYFHZG?=
 =?us-ascii?Q?neBg2neg6MErJuTVHEI7uNCaqLfMz289HzRWzcG3ekZlCJPfpqmfAM2daAuG?=
 =?us-ascii?Q?lQjJvGJB6/uGXRnmDuwesBgrxcLmopS6kwPcGX3QAYA0o5rUx3VRBXBvcpp9?=
 =?us-ascii?Q?QzTaANXfNZRwC2ptNVhe/iktnMR/GZTClymPk6E2B429y5bEH7fEC2glSSPo?=
 =?us-ascii?Q?ub3BL0OzQ0R7QstLi85bbPlaPmn41E6X0AkZVpMxh8BSvNdis7eZExRncInm?=
 =?us-ascii?Q?H5iO0J9b3VDXrIvVEqfKg8riXyDDcjtz1CuxHqQR+vOS/DI6yz1K1Vh9Pfa4?=
 =?us-ascii?Q?hxbS97NAl59MTp5dtyqsNz5x9EMAuReBa6HXMs4tXupp/awiCKs17vAGzWLZ?=
 =?us-ascii?Q?eXhJT9JK2sxIEYINu0WqKyUlvRyE+p86h8NnV2NL+hCLK3miL24DDCKQ4UNg?=
 =?us-ascii?Q?XmbbpDo44DwD1xtrXcnCLsUpM8ccOyFZexsByGLyizFPkdCgZFXhDgG49hLm?=
 =?us-ascii?Q?udZ0wNuG4RCBd7Ob1qPzPLt9U2i+C8zdNpJg7zOQ2Ml51+AEx/2N6HsSd5Hn?=
 =?us-ascii?Q?TyekYXJ2gHSkxg+iiioXmjDjzBwEnF68c38QYx71wsZWt4gEu6rUno0ZdRl2?=
 =?us-ascii?Q?mjdQOFAFwGH+MwjZFMDLKzRKwCAduE2qi4bn++SD3i1NabqmsLui0jfJgdQb?=
 =?us-ascii?Q?7Ku5+x5OvxIR5U8c9GQnn4fumTskf85nuVfWXToGlC7JIb+q3KUR8xsXG1W0?=
 =?us-ascii?Q?Xus0AZqqHwkA1vD4M3qMuox2EIQ01NRa95XRkYaQwdM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2021 03:43:08.3778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-Network-Message-Id: 51c3bbb3-a6dd-4459-67a6-08d8b38783ae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eyrNyiEpSpGgJOPj51kWGh6qW6BCRB2VopuLMWm6soaKGXosE3YGIANlSN8UINBT1YesqpVnLWvn4wKXfcViB/ivsBPzAJIDK0f7/3ydaAg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4437
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9857 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 phishscore=0 spamscore=0 mlxlogscore=973 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101080018
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9857 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 clxscore=1015 spamscore=0 impostorscore=0 priorityscore=1501 mlxscore=0
 adultscore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2101080018
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Bean,

> sprintf and snprintf may cause output defect in sysfs content, it is
> better to use new added sysfs_emit function which knows the size of
> the temporary buffer.

Applied to 5.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering