Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Xu Wang <vulab@iscas.ac.cn>, "lars@metafoo.de" <lars@metafoo.de>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ASoC: adau17x1: Remove redundant null check before
 clk_disable_unprepare
Thread-Topic: [PATCH] ASoC: adau17x1: Remove redundant null check before
 clk_disable_unprepare
Thread-Index: AQHW5ZqRwsXhsRyK6kyDZks1e039iKodcp6w
Date:   Fri, 8 Jan 2021 09:19:55 +0000
Message-ID: <CY4PR03MB26316C0C18A6541519CF9FA399AE0@CY4PR03MB2631.namprd03.prod.outlook.com>
References: <20210108084456.6603-1-vulab@iscas.ac.cn>
In-Reply-To: <20210108084456.6603-1-vulab@iscas.ac.cn>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 88b552af-27ca-4ba2-658e-08d8b3b68ffa
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2021 09:19:55.2967
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bVVByUhJ6jsspvRKMeXPmE6I/znAsU/4MIfR9HBAqXxM5sJeBdoRItlPeylRVqWbP46tpEHZ7uP858DLKO6yfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3255
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737
 definitions=2021-01-08_06:2021-01-07,2021-01-08 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 phishscore=0
 impostorscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 adultscore=0
 suspectscore=0 bulkscore=0 spamscore=0 priorityscore=1501
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2101080051
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Xu Wang <vulab@iscas.ac.cn>
> Sent: Friday, January 8, 2021 9:45 AM
> To: lars@metafoo.de; Sa, Nuno <Nuno.Sa@analog.com>;
> lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz;
> tiwai@suse.com; alsa-devel@alsa-project.org
> Cc: linux-kernel@vger.kernel.org
> Subject: [PATCH] ASoC: adau17x1: Remove redundant null check
> before clk_disable_unprepare
>=20
>=20
> Because clk_disable_unprepare() already checked NULL clock
> parameter,
> so the additional check is unnecessary, just remove it.
>=20
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  sound/soc/codecs/adau17x1.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/sound/soc/codecs/adau17x1.c
> b/sound/soc/codecs/adau17x1.c
> index 30e072c80ac1..546ee8178038 100644
> --- a/sound/soc/codecs/adau17x1.c
> +++ b/sound/soc/codecs/adau17x1.c
> @@ -1095,8 +1095,7 @@ void adau17x1_remove(struct device *dev)
>  {
>  	struct adau *adau =3D dev_get_drvdata(dev);
>=20
> -	if (adau->mclk)
> -		clk_disable_unprepare(adau->mclk);
> +	clk_disable_unprepare(adau->mclk);
>  }
>  EXPORT_SYMBOL_GPL(adau17x1_remove);

This is fine by me but since you are touching this, you could also just rep=
lace the
remove() hook in all the users with devm_add_action_or_reset().

- Nuno S=E1